GNOME Bugzilla – Bug 655428
Dialog button theming
Last modified: 2011-08-03 10:25:33 UTC
Created attachment 192756 [details] Dialog button details There are a few things missing from the shell's dialog buttons: * Labels should be bold and white * Buttons containing the default action should have a 2px wide stroke * The fill needs a stronger gradient * Buttons should light up on hover An image containing a screenshot of the current state, the mockup and some other details is attached.
Created attachment 193087 [details] [review] patch - theme changes to the dialog buttons This patch makes most of the required changes. It misses a couple of things though: * Multiple stops on the gradient - requires bug 624383 * The buttons are currently too tall (40px high). They should be more like 32px high. * It doesn't bold the button labels. It looks good on the mockups but seems too heavy in real life.
Review of attachment 193087 [details] [review]: (In reply to comment #1) > This patch makes most of the required changes. It misses a couple of things > though: > [...] > * The buttons are currently too tall (40px high). They should be more like > 32px high. Fix it then? Either choose another font size or decrease the top/bottom padding. This likes like a change which is perfectly in scope for this bug :-) Other than that just some minor nits: ::: data/theme/gnome-shell.css @@ +1049,3 @@ +.summary-boxpointer:hover { + -arrow-border-colour: #babdb6; Trailing space (not a big deal, but Linus apparently dislikes them, so git is pretty anal about it) ::: js/ui/modalDialog.js @@ +84,2 @@ this._buttonLayout = new St.BoxLayout({ style_class: 'modal-dialog-button-box', + opacity: 255, Actors default to full opacity, so instead of changing the property value, you can just remove it.
Created attachment 193144 [details] [review] patch - theme changes to the dialog buttons Updated patch with the recommended changes. Thanks for the advice Florian!
Review of attachment 193144 [details] [review]: Go for it!