After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 655362 - [decklink] Add support for Windows
[decklink] Add support for Windows
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Normal normal
: 0.10.23
Assigned To: David Schleef
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-07-26 16:22 UTC by Joshua M. Doe
Modified: 2014-12-03 16:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
use mutexes (1.88 KB, patch)
2011-07-26 16:22 UTC, Joshua M. Doe 		none Details | Review
fix debugging in capture.cpp by making category extern (1.77 KB, patch)
2011-07-26 16:23 UTC, Joshua M. Doe 		none Details | Review
send NEWSEGMENT on start, send warning instead of error on dropped frames (6.48 KB, patch)
2011-07-26 16:23 UTC, Joshua M. Doe 		none Details | Review
add support for Windows (469.48 KB, patch)
2011-07-26 16:24 UTC, Joshua M. Doe 		none Details | Review

Description Joshua M. Doe 2011-07-26 16:22:07 UTC 
The first three patches fix minor bugs or issues preventing compilation, while the fourth adds necessary Windows-specific files and handles the COM bits. This has not been tested at all on Linux, and I know I've at least broken the build since I've moved Linux-specific files to a subdirectory without updating the Makefile, but I figure it's better for someone to test the patches on Linux and find any other issues that might exist.
Comment 1 Joshua M. Doe 2011-07-26 16:22:55 UTC 
Created attachment 192682 [details] [review]
use mutexes
Comment 2 Joshua M. Doe 2011-07-26 16:23:36 UTC 
Created attachment 192683 [details] [review]
fix debugging in capture.cpp by making category extern
Comment 3 Joshua M. Doe 2011-07-26 16:23:52 UTC 
Created attachment 192684 [details] [review]
send NEWSEGMENT on start, send warning instead of error on dropped frames
Comment 4 Joshua M. Doe 2011-07-26 16:24:16 UTC 
Created attachment 192685 [details] [review]
add support for Windows
Comment 5 Joshua M. Doe 2011-07-26 18:04:25 UTC 
One important point I failed to mention is that decklinksrc only works with sinks when sync=false. It must be some timing issue, but all the timestamps seemed fine to me, so hopefully someone else will have better luck finding the problem.
Comment 6 David Schleef 2011-07-27 04:26:55 UTC 
Looks generally good, didn't review the large patch.  Will merge soon.
Comment 7 David Schleef 2011-08-22 02:08:32 UTC 
pushed, with minor modifications.
Comment 8 Josh Doe 2011-08-22 12:04:10 UTC 
Thanks David!
Comment 9 Sebastian Dröge (slomo) 2014-12-03 14:51:28 UTC 
How did you get the DecklinkDispatch.cpp for Windows? It doesn't seem to be included in the SDK and is also not generated by midl.exe
Comment 10 Joshua M. Doe 2014-12-03 14:57:18 UTC 
Good question, I can't recall, even after looking over the file.
Comment 11 Sebastian Dröge (slomo) 2014-12-03 16:01:19 UTC 
That's inconvenient :) I updated the headers of the SDK inside the plugin earlier today... the Windows part should still work, but the DeckLinkDispatch.cpp is outdated and would ideally have some more functions like it has for OSX and Linux.