After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 655361 - pcapparse: fix SLL parsing
pcapparse: fix SLL parsing
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other Linux
: Normal normal
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-07-26 16:19 UTC by Felipe Contreras (banned)
Modified: 2011-07-27 09:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (1.66 KB, patch)
2011-07-26 16:19 UTC, Felipe Contreras (banned)
committed Details | Review

Description Felipe Contreras (banned) 2011-07-26 16:19:01 UTC
Created attachment 192681 [details] [review]
Proposed patch

The current code is not checking for ethernet type, as it's supposed to, but link layer device type and it's hard-coded to only accept dumps from ethernet (ARPHRD_ETHER; 1). We don't care where the dump was fetched from (wlan, 3G, etc.)

What we care about is the that the ethernet type is IP (ETHERNET_IP; 0x800), which is clearly field 14:

http://www.tcpdump.org/pcap3_man.html

And do a bit of cleanup.
Comment 1 Olivier Crête 2011-07-26 21:54:32 UTC
Review of attachment 192681 [details] [review]:

If it works fine, patch looks ok to me
Comment 2 Mark Nauwelaerts 2011-07-27 08:37:48 UTC
Thanks.

commit 046af98b301396570488a56443fdd1d8c5aacd79
Author: Felipe Contreras <felipe.contreras@nokia.com>
Date:   Tue Jul 26 19:11:16 2011 +0300

    pcapparse: fix SLL parsing
    
    The current code is not checking for ethernet type, as it's supposed to,
    but link layer device type and it's hard-coded to only accept dumps from
    ethernet (ARPHRD_ETHER; 1). We don't care where the dump was fetched
    from (wlan, 3G, etc.)
    
    What we care about is the that the ethernet type is IP (ETHERNET_IP;
    0x800), which is clearly field 14:
    
    http://www.tcpdump.org/pcap3_man.html
    
    And do a bit of cleanup.
    
    Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>