After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 655213 - Update for libfolks API changes to AvatarDetails
Update for libfolks API changes to AvatarDetails
Status: RESOLVED FIXED
Product: gnome-contacts
Classification: Core
Component: general
0.1.x
Other All
: Normal major
: ---
Assigned To: Alexander Larsson
Alexander Larsson
Depends on: 650414 655911
Blocks:
 
 
Reported: 2011-07-24 16:11 UTC by Philip Withnall
Modified: 2011-08-12 09:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Update for libfolks API changes to AvatarDetails (2.50 KB, patch)
2011-07-24 16:17 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2011-07-24 16:11:59 UTC 
Bug #650414 changes how avatars are handled in libfolks. Patch coming up to
update gnome-contacts accordingly.

(Note that the patch in bug #650414 hasn't yet been committed, but it hopefully
will be soon.)
Comment 1 Philip Withnall 2011-07-24 16:17:44 UTC 
Created attachment 192564 [details] [review]
Update for libfolks API changes to AvatarDetails
Comment 2 Matthias Clasen 2011-07-25 01:49:19 UTC 
Given that Alex is currently on vacation, and this patch looks pretty straightforward, you should probably just commit it when the libfolks api change lands.

Is this material for the upcoming 3.1.4 gnome release ?
Comment 3 Philip Withnall 2011-07-25 07:25:20 UTC 
(In reply to comment #2)
> Given that Alex is currently on vacation, and this patch looks pretty
> straightforward, you should probably just commit it when the libfolks api
> change lands.

OK.

> Is this material for the upcoming 3.1.4 gnome release ?

Not really. It's intended for whenever Travis decides that folks 0.6 is ready. (I don't know when this is.) Definitely before GNOME 3.2.
Comment 4 Travis Reitter 2011-07-25 16:47:53 UTC 
(In reply to comment #3)
> (In reply to comment #2)
> > Given that Alex is currently on vacation, and this patch looks pretty
> > straightforward, you should probably just commit it when the libfolks api
> > change lands.
> 
> OK.
> 
> > Is this material for the upcoming 3.1.4 gnome release ?
> 
> Not really. It's intended for whenever Travis decides that folks 0.6 is ready.
> (I don't know when this is.) Definitely before GNOME 3.2.

Basically, my blockers for 0.6 are bug #653684 and bug #652643. I'm hoping to get them both resolved by Monday and make the release.
Comment 5 Javier Jardón (IRC: jjardon) 2011-08-11 11:44:13 UTC 
Seems that the patch of comment #1 was applied, should we close this?

http://git.gnome.org/browse/gnome-contacts/commit/?id=e49364b30102c720319473579c1e6efc3a799ae7