After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 655119 - datetime: Add support for chrony on Fedora
datetime: Add support for chrony on Fedora
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: plugins
3.1.x
Other Linux
: Normal enhancement
: ---
Assigned To: Tomas Bzatek
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2011-07-22 12:43 UTC by Tomas Bzatek
Modified: 2011-09-06 12:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Original patch by Miroslav Lichvar (3.30 KB, patch)
2011-07-22 12:43 UTC, Tomas Bzatek 		none Details | Review
Minor whitespace fixes (3.30 KB, patch)
2011-07-22 12:45 UTC, Tomas Bzatek 		needs-work Details | Review

Description Tomas Bzatek 2011-07-22 12:43:11 UTC 
Created attachment 192454 [details] [review]
Original patch by Miroslav Lichvar

This patch adds support for chrony, the default NTP client in Fedora 16. Just a simple test for available service.

Fedora feature page: http://fedoraproject.org/wiki/Features/ChronyDefaultNTP
Original Fedora bug: https://bugzilla.redhat.com/show_bug.cgi?id=723212
Comment 1 Tomas Bzatek 2011-07-22 12:45:39 UTC 
Created attachment 192455 [details] [review]
Minor whitespace fixes
Comment 2 Tomas Bzatek 2011-07-22 12:48:46 UTC 
-- bug 654970 looks to be somewhat related, good idea of sharing some code.
Comment 3 Matthias Clasen 2011-07-22 22:27:11 UTC 
I think it is fine to keep accepting distro-specific patches until the systemd service is ready to replace this.
Comment 4 Cosimo Cecchi 2011-07-29 00:24:19 UTC 
Review of attachment 192455 [details] [review]:

::: plugins/datetime/gsd-datetime-mechanism-fedora.c
@@ +39,3 @@
+                return "ntp";
+        return NULL;
+}

Just a drive-by comment: why don't you just return "chronyd" and "ntpd" here instead of appending "d" to the returned string manually later every time?
Comment 5 Bastien Nocera 2011-08-01 15:24:30 UTC 
Comment on attachment 192455 [details] [review]
Minor whitespace fixes

As per Cosimo's comment (really not making this any more readable otherwise).
Comment 6 Matthias Clasen 2011-08-23 04:43:11 UTC 
The systemd service has ntp support now, so switching over to that would be another option.
Comment 7 Tomas Bzatek 2011-09-02 16:38:15 UTC 
(In reply to comment #6)
> The systemd service has ntp support now, so switching over to that would be
> another option.

Working on this.
Comment 8 Bastien Nocera 2011-09-03 10:31:12 UTC 
(In reply to comment #7)
> (In reply to comment #6)
> > The systemd service has ntp support now, so switching over to that would be
> > another option.
> 
> Working on this.

Note that if you want to have support for chrony, it should happen with a corrected version of the patch. When the systemd ntp service support is merged, I will remove the support for other systems altogether so that's one for 3.4.
Comment 9 Bastien Nocera 2011-09-06 12:55:15 UTC 
Fixed in master for GNOME 3.2. We'll be removing that code in GNOME 3.4, see bug 658352.

commit bcf00c394e71bde04698e51a6930cb8d2940aadf
Author: Tomas Bzatek <tbzatek@redhat.com>
Date:   Tue Sep 6 13:41:15 2011 +0100

    datetime: Allow chrony to be used on Fedora
    
    This patch adds support for chrony, the default NTP client in Fedora 16.
    
    Fedora feature page:
    http://fedoraproject.org/wiki/Features/ChronyDefaultNTP
    Original Fedora bug:
    https://bugzilla.redhat.com/show_bug.cgi?id=723212
    
    https://bugzilla.gnome.org/show_bug.cgi?id=655119