After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 655110 - shell: Port to new gnome-menus API
shell: Port to new gnome-menus API
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: shell
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on: 647968
Blocks:
 
 
Reported: 2011-07-22 11:07 UTC by Vincent Untz
Modified: 2011-08-01 17:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shell: Port to new gnome-menus API (12.41 KB, patch)
2011-07-22 11:07 UTC, Vincent Untz 		committed Details | Review

Description Vincent Untz 2011-07-22 11:07:16 UTC 
We're considerably changing the gnome-menus API in bug 647968. This patch updates g-c-c to work fine with the new API.

It requires moving some stuff from icon names to GIcon, but I don't think it's much of an issue.
Comment 1 Vincent Untz 2011-07-22 11:07:25 UTC 
Created attachment 192448 [details] [review]
shell: Port to new gnome-menus API
Comment 2 Rodrigo Moya 2011-07-22 16:31:28 UTC 
Review of attachment 192448 [details] [review]:

Looks good to me
Comment 3 Matthias Clasen 2011-07-22 22:24:16 UTC 
Looks good to me too
Comment 4 Vincent Untz 2011-08-01 17:42:12 UTC 
Thanks, pushed.