After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 655064 - Drop ClutterGLXTexturePixmap
Drop ClutterGLXTexturePixmap
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2011-07-21 16:47 UTC by Emmanuele Bassi (:ebassi)
Modified: 2011-07-22 10:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use Cogl API to check for TfP extension support (1.86 KB, patch)
2011-07-21 16:47 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review
Do not use ClutterGLXTexturePixmap (2.28 KB, patch)
2011-07-21 16:47 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review
Do not check for clutter-glx-texture-pixmap.h (1.32 KB, patch)
2011-07-21 16:47 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review

Description Emmanuele Bassi (:ebassi) 2011-07-21 16:47:47 UTC 
The class has been deprecated, and it's been a simple compatibility API for longer than that.
Comment 1 Emmanuele Bassi (:ebassi) 2011-07-21 16:47:49 UTC 
Created attachment 192389 [details] [review]
Use Cogl API to check for TfP extension support

Do not use the ClutterGLXTexturePixmap method, since it's been
deprecated and it's just a convenience function around the Cogl
API anyway.
Comment 2 Emmanuele Bassi (:ebassi) 2011-07-21 16:47:52 UTC 
Created attachment 192390 [details] [review]
Do not use ClutterGLXTexturePixmap

MetaShapedTexture can be a ClutterX11TexturePixmap sub-class, given that
ClutterGLXTexturePixmap is just a shim compatibility layer since Clutter
1.4, and it's been deprecated.
Comment 3 Emmanuele Bassi (:ebassi) 2011-07-21 16:47:55 UTC 
Created attachment 192391 [details] [review]
Do not check for clutter-glx-texture-pixmap.h

Nothing uses that header any more.
Comment 4 Owen Taylor 2011-07-21 18:30:32 UTC 
Review of attachment 192389 [details] [review]:

Sure fine. (Last time this check came up, I think I just wanted to kill it, but other people saw value in it.)
Comment 5 Owen Taylor 2011-07-21 18:30:57 UTC 
Review of attachment 192390 [details] [review]:

Sure
Comment 6 Owen Taylor 2011-07-21 18:31:23 UTC 
Review of attachment 192391 [details] [review]:

Sure
Comment 7 Emmanuele Bassi (:ebassi) 2011-07-22 10:48:19 UTC 
thanks for the quick review

Attachment 192389 [details] pushed as ffa2310 - Use Cogl API to check for TfP extension support
Attachment 192390 [details] pushed as f396a7a - Do not use ClutterGLXTexturePixmap
Attachment 192391 [details] pushed as 385887c - Do not check for clutter-glx-texture-pixmap.h