After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654979 - Add simple gssdp discoverer tool
Add simple gssdp discoverer tool
Status: RESOLVED FIXED
Product: gupnp-tools
Classification: Other
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: GUPnP Maintainers
GUPnP Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-07-20 16:38 UTC by Jens Georg
Modified: 2019-02-22 05:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add simple gssdp discoverer tool (5.84 KB, patch)
2011-07-20 16:38 UTC, Jens Georg 		none Details | Review
Add gssdp-discover tool (7.34 KB, patch)
2011-07-29 09:01 UTC, Jens Georg 		accepted-commit_now Details | Review

Description Jens Georg 2011-07-20 16:38:18 UTC 
Add gssdp-discover, a simple command line tool to issue M-SEARCH
requests for specific targets
Comment 1 Jens Georg 2011-07-20 16:38:20 UTC 
Created attachment 192319 [details] [review]
Add simple gssdp discoverer tool
Comment 2 Zeeshan Ali 2011-07-27 00:35:30 UTC 
Looks good. Just one thing: Since the tool can't do anything without the target option, I suggest you make that a required argument instead.
Comment 3 Jens Georg 2011-07-27 06:43:46 UTC 
(In reply to comment #2)
> Looks good. Just one thing: Since the tool can't do anything without the target
> option,

Yes it does, as the help says:

+        { "target", 't', 0, G_OPTION_ARG_STRING, &target, "SSDP TARGET to search for (default: ssdp:all)"
Comment 4 Zeeshan Ali 2011-07-27 12:10:39 UTC 
(In reply to comment #3)
> (In reply to comment #2)
> > Looks good. Just one thing: Since the tool can't do anything without the target
> > option,
> 
> Yes it does, as the help says:
> 
> +        { "target", 't', 0, G_OPTION_ARG_STRING, &target, "SSDP TARGET to
> search for (default: ssdp:all)"

Ah! In that case, just add a print telling user that we are doing something. E.g Searching for SSDP resource(s) 'TARGET'.

Oh and one more thing. This tool isn't using any gssdp internal api, right? If so, we better put it in gupnp-tools. Thats the only reason device-sniffer isn't in gupnp-tools.
Comment 5 Jens Georg 2011-07-29 08:29:10 UTC 
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Looks good. Just one thing: Since the tool can't do anything without the target
> > > option,
> > 
> > Yes it does, as the help says:
> > 
> > +        { "target", 't', 0, G_OPTION_ARG_STRING, &target, "SSDP TARGET to
> > search for (default: ssdp:all)"
> 
> Ah! In that case, just add a print telling user that we are doing something.
> E.g Searching for SSDP resource(s) 'TARGET'.
> 
> Oh and one more thing. This tool isn't using any gssdp internal api, right? If
> so, we better put it in gupnp-tools. Thats the only reason device-sniffer isn't
> in gupnp-tools.

Ok, I thought the split was gssdp vs. gupnp. Will move there.
Comment 6 Jens Georg 2011-07-29 09:01:23 UTC 
Created attachment 192857 [details] [review]
Add gssdp-discover tool

A simple tool that scans the network for a given resource.
Comment 7 Zeeshan Ali 2011-07-29 18:50:45 UTC 
Review of attachment 192857 [details] [review]:

Except for the '{}' around single-line blocks, looks good.
Comment 8 Jens Georg 2011-07-30 07:47:16 UTC 
(In reply to comment #7)
> Review of attachment 192857 [details] [review]:
> 
> Except for the '{}' around single-line blocks, looks good.

Fixed and pushed.