After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654932 - all: add a Documents account type
all: add a Documents account type
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-07-19 23:29 UTC by Cosimo Cecchi
Modified: 2011-07-20 18:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
all: add a Documents account type (6.19 KB, patch)
2011-07-19 23:29 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2011-07-19 23:29:29 UTC 
Hi; the attached patch adds support in g-o-a for a Documents account type, and implements it for the google backend.
Comment 1 Cosimo Cecchi 2011-07-19 23:29:36 UTC 
Created attachment 192270 [details] [review]
all: add a Documents account type
Comment 2 David Zeuthen (not reading bugmail) 2011-07-20 17:25:32 UTC 
(In reply to comment #1)
> Created an attachment (id=192270) [details] [review]
> all: add a Documents account type

Generally sounds like a good idea, but

 1. You're adding a scope so you need to bump get_crededentials_generation()

 2. It needs a GtkSwitch in the UI
Comment 3 Cosimo Cecchi 2011-07-20 18:44:59 UTC 
Pushed with the credentials generation version bump.
[ The switch is automatically appended by calling goa_util_add_row_switch_from_keyfile() ]

Attachment 192270 [details] pushed as ba51633 - all: add a Documents account type