After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654727 - alpha: Don't use the GClosure to compute the alpha when possible
alpha: Don't use the GClosure to compute the alpha when possible
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2011-07-16 10:11 UTC by Damien Lespiau
Modified: 2011-07-18 14:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
alpha: Don't use the GClosure to compute the alpha when possible (2.62 KB, patch)
2011-07-16 10:11 UTC, Damien Lespiau
none Details | Review
a slightly different version of the patch in attachment 192080: instead of keeping the Closure around, let's split the two paths - we either use a decomposed func/data/notify tuple or we use the GClosure. (3.70 KB, patch)
2011-07-18 14:05 UTC, Emmanuele Bassi (:ebassi)
committed Details | Review

Description Damien Lespiau 2011-07-16 10:11:53 UTC
Setting up the call and calling the GClosure was showing up in profiles
and seemed an easy one to remove.

Instead of calling the closure, let's remember the alpha func and the
user_data when possible (ie set_mode() and set_func()) and use it in
get_alpha().
Comment 1 Damien Lespiau 2011-07-16 10:11:55 UTC
Created attachment 192080 [details] [review]
alpha: Don't use the GClosure to compute the alpha when possible
Comment 2 Emmanuele Bassi (:ebassi) 2011-07-18 14:05:48 UTC
Created attachment 192186 [details] [review]
a slightly different version of the patch in attachment 192080 [details] [review]: instead of keeping the Closure around, let's split the two paths - we either use a decomposed func/data/notify tuple or we use the GClosure.
Comment 3 Emmanuele Bassi (:ebassi) 2011-07-18 14:29:04 UTC
pushed to master