After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654726 - text: Fix the default value of "editable"
text: Fix the default value of "editable"
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: ClutterText
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2011-07-16 09:18 UTC by Damien Lespiau
Modified: 2011-07-18 14:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
text: Fix the default value of "editable" (900 bytes, patch)
2011-07-16 09:18 UTC, Damien Lespiau 		none Details | Review
text: Fix the default value of "editable" (1.21 KB, patch)
2011-07-18 12:58 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review

Description Damien Lespiau 2011-07-16 09:18:27 UTC 
It can break some applications that were relying on the wrong default
behaviour.
Comment 1 Damien Lespiau 2011-07-16 09:18:29 UTC 
Created attachment 192079 [details] [review]
text: Fix the default value of "editable"

The "editable" property is documented to default to FALSE, but is
initialized to TRUE in the _init() function.

Initialize "editable" as documented.
Comment 2 Emmanuele Bassi (:ebassi) 2011-07-18 12:57:07 UTC 
mmh, looking at Mx, it expects the Text actor to be !editable by default - same as St. so if we set editable = true by default they'd need to be changed.

it's probably better to fix the default value of the GParamSpec instead.
Comment 3 Emmanuele Bassi (:ebassi) 2011-07-18 12:58:43 UTC 
Created attachment 192182 [details] [review]
text: Fix the default value of "editable"

The "editable" property is documented to default to TRUE, but is
initialized to FALSE in the _init() function.

Third party code would be affected if we changed the default to be
TRUE, so we have to change the default value in the GParamSpec.
Comment 4 Emmanuele Bassi (:ebassi) 2011-07-18 14:28:36 UTC 
Attachment 192182 [details] pushed as 4d58534 - text: Fix the default value of "editable"