GNOME Bugzilla – Bug 654707
[PATCH] favorite-apps: Use firefox.desktop & libreoffice-writer.desktop
Last modified: 2011-08-22 18:41:10 UTC
At least Debian, OpenSUSE & Ubuntu ship firefox.desktop instead of mozilla-firefox.desktop. Also Linux distributions have effectively chosen LibreOffice over OpenOffice.org.
Created attachment 192061 [details] [review] updated-favorite-apps
The libreoffice change is certainly right. For firefox, maybe we can push the fedora packagers to switch to (or add) a firefox.desktop
Well, Fedora's source RPM already has firefox.desktop. I think it's just their firefox.spec which installs it as mozilla-firefox.desktop instead so it should be a very easy fix for the Fedora packagers.
Review of attachment 192061 [details] [review]: Looks fine, and re fedora we got the same vendor prefix mess with gnome-nautilus.desktop vs. nautilus.desktop and just fixed it anyway. The patch should contain a commit message though; and put a link to the bug at the bottom of rather then (#bugnr) in the subject.
Created attachment 192877 [details] [review] 0002-favorite-apps-Use-libreoffice-writer-firefox.desktop.patch Thanks for the review. Here's an improved version.
If you can submit the libreoffice change as a separate patch, we could land that, and then we'd just be waiting for F15 to change the Firefox desktop filename.
Why can't GNOME make a change without consulting Fedora first? Isn't it the distro packagers' job to package what upstream creates? Fedora 15 doesn't use Gnome Shell 3.1.* so why does Fedora 15 need to change now instead of waiting for Fedora 16? As I mentioned in comment 3, they actually already have firefox.desktop in their package; they just told their .spec to ship it as mozilla-firefox.desktop instead. It should just be a one line change in Fedora 16 as Gnome Shell 3.1.5 is released if Fedora were doing what I would have expected. But it sounds like Fedora intends to support Gnome Shell 3.0.* and 3.1.* and the bleeding-edge git snapshot in their supposedly stable release. So it would additionally require a Gnome Shell 3.0 patch. If Fedora wants to act different than every other distribution, why should that slow down Gnome Shell doing what's best? And can't they still make the change immediately after?
Or I guess they could do a symlink or something instead of patching Gnome Shell but still.
I don't have commit access and I don't intend to split a perfectly good one line patch into two parts for the wrong reason. I don't care if my name shows up in the git log for this; I'd just like someone to fix this bug. The LibreOffice part is broken with Fedora right now and has been for months. The Firefox part has to be patched by several distros (including Fedora the way I read the firefox .spec).
Review of attachment 192877 [details] [review]: Looks good to me, thank you!
> The Firefox part has to be patched by several distros (including Fedora the way > I read the firefox .spec). That is part of the problem here. This is not about giving Fedora some special role, it is about getting things fixed at the source... we are pushing to get mozilla to include a proper desktop file. But we should get this change committed regardless.
Thanks!