GNOME Bugzilla – Bug 654700
next/previous tab keyboard shortcuts
Last modified: 2012-09-05 14:09:03 UTC
Hi nautilus accepts both [Ctr+Alt+Page Up/Down] and [Ctr+Page Up/Down] to cycle between tabs. However, they have different behavior when at the last or first tab. The [Ctr+Page Up/Down] shortcut is not cyclical, moving to the next at the end doesn't go to the first tab as it happens when using [Ctr+Alt+Page Up/Down]. If it's confusing, here's how to replicate 1 - Open natilus 2 - Open a new tab 3 - Select the first tab 4 - Press [Ctr+Page Up]. Moves to the next tab. 5 - Select the last tab. 6 - Press [Ctr+Page Up]. Nothing happens. 7 - Select the first tab 8 - Press [Ctr+Alt+Page Up]. Moves to the next tab. 9 - Select the last tab. 10 - Press [Ctr+Alt+Page Up]. Moves to the first tab. This is on Nautilus 2.30.1 on Debian stable (Squeeze).
Just FYI, Nautilus 2.30 is obsolete (supported in upstream are 2.32 and 3.0) so a potential fix (if still an issue) will only be available in supported versions. Retesting with a recent version is welcome.
Created attachment 223496 [details] [review] Make tab change action consistent with GTK's
Review of attachment 223496 [details] [review]: Thanks, looks good! ::: src/nautilus-notebook.c @@ -534,1 @@ - return nautilus_notebook_is_valid_relative_position (notebook, offset); Can we also remove this now?
Review of attachment 223496 [details] [review]: ::: src/nautilus-notebook.c @@ -534,1 @@ - return nautilus_notebook_is_valid_relative_position (notebook, offset); Don't think so. It is used by the tab reordering code.
Review of attachment 223496 [details] [review]: ::: src/nautilus-notebook.c @@ -534,1 @@ - return nautilus_notebook_is_valid_relative_position (notebook, offset); I mean nautilus_notebook_can_set_current_page_relative(), it looks like it's unused now.
Review of attachment 223496 [details] [review]: ::: src/nautilus-notebook.c @@ -534,1 @@ - return nautilus_notebook_is_valid_relative_position (notebook, offset); I did remove it.
Review of attachment 223496 [details] [review]: Sorry for the noise; I was confused by the fact that git-bz showed it in blue instead of red. Looking at the diff, you're right :) Feel free to push