After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654691 - vte: use gtk_drag_check_threshold()
vte: use gtk_drag_check_threshold()
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
[fixed-next]
Depends on:
Blocks:
 
 
Reported: 2011-07-15 17:52 UTC by Dan Winship
Modified: 2014-04-11 17:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
vte: use gtk_drag_check_threshold() (5.64 KB, patch)
2011-07-15 17:52 UTC, Dan Winship 		none Details | Review
vte: use gtk_drag_check_threshold() (4.83 KB, patch)
2011-08-16 18:35 UTC, Dan Winship 		committed Details | Review

Description Dan Winship 2011-07-15 17:52:28 UTC 
When processing motion events, don't start selecting until the pointer
has moved at least the gtk drag threshold distance.

Fixes the problem where, when clicking to select a terminal, you often
end up selecting a bit of text where you clicked, which is especially
annoying when you were planning to middle-button-paste something from
another window.
Comment 1 Dan Winship 2011-07-15 17:52:29 UTC 
Created attachment 192046 [details] [review]
vte: use gtk_drag_check_threshold()
Comment 2 Dan Winship 2011-07-15 17:55:43 UTC 
(this is particularly annoying on tablet PCs, where tapping on a terminal almost always ends up starting a selection, due to the generally less precise nature of the input device.)
Comment 3 Christian Persch 2011-08-16 17:35:34 UTC 
If I read the patch correctly, it will change the deselection behaviour a bit: Suppose some text is selected in the vte widget, and then you click in it without moving the mouse. Without the patch, the text is immediately deselected, while with your patch it only is deselected on button-release. Right?
GtkEntry and GtkTextView work the same way as vte currently in this respect, so I'd like to preserve consistency with them.
Comment 4 Dan Winship 2011-08-16 18:35:47 UTC 
Created attachment 193986 [details] [review]
vte: use gtk_drag_check_threshold()

fix to deselect on button-press, not button-release.

Not sure why I initially wrote the patch the other way, but there
don't seem to be any regressions with the change.
Comment 5 Christian Persch 2011-10-28 13:00:06 UTC 
Committed to vte-0-32 branch; leaving open for applying to vte-next.