GNOME Bugzilla – Bug 654691
vte: use gtk_drag_check_threshold()
Last modified: 2014-04-11 17:55:18 UTC
When processing motion events, don't start selecting until the pointer has moved at least the gtk drag threshold distance. Fixes the problem where, when clicking to select a terminal, you often end up selecting a bit of text where you clicked, which is especially annoying when you were planning to middle-button-paste something from another window.
Created attachment 192046 [details] [review] vte: use gtk_drag_check_threshold()
(this is particularly annoying on tablet PCs, where tapping on a terminal almost always ends up starting a selection, due to the generally less precise nature of the input device.)
If I read the patch correctly, it will change the deselection behaviour a bit: Suppose some text is selected in the vte widget, and then you click in it without moving the mouse. Without the patch, the text is immediately deselected, while with your patch it only is deselected on button-release. Right? GtkEntry and GtkTextView work the same way as vte currently in this respect, so I'd like to preserve consistency with them.
Created attachment 193986 [details] [review] vte: use gtk_drag_check_threshold() fix to deselect on button-press, not button-release. Not sure why I initially wrote the patch the other way, but there don't seem to be any regressions with the change.
Committed to vte-0-32 branch; leaving open for applying to vte-next.