After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654689 - Slightly broken Introspection build
Slightly broken Introspection build
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
1.29.x
Other Linux
: Normal major
: ---
Assigned To: pango-maint
pango-maint
: 635399 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-07-15 16:38 UTC by Rico Tzschichholz
Modified: 2011-07-22 15:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix introspection build using uninstalled GIRs (1.96 KB, patch)
2011-07-15 16:38 UTC, Rico Tzschichholz 		reviewed Details | Review

Description Rico Tzschichholz 2011-07-15 16:38:25 UTC 
Created attachment 192040 [details] [review]
Fix introspection build using uninstalled GIRs

The build doesn't consequently using the currently build and uninstalled introspection data and fails to build in a chroot.
Comment 1 Colin Walters 2011-07-15 17:00:28 UTC 
Review of attachment 192040 [details] [review]:

::: pango/Makefile.am
@@ +328,2 @@
 PangoXft-1.0.gir: libpangoxft-1.0.la
+PangoXft-1.0.gir: Pango-1.0.gir PangoFT2-1.0.gir

This line shouldn't be necessary; PangoFT2 depends on Pango.

@@ +334,3 @@
 PangoXft_1_0_gir_LIBS = libpangoxft-1.0.la
 PangoXft_1_0_gir_CFLAGS = -I$(top_srcdir) $(PANGO_CFLAGS)
+PangoXft_1_0_gir_SCANNERFLAGS = --include-uninstalled=$(builddir)/Pango-1.0.gir --include-uninstalled=$(builddir)/PangoFT2-1.0.gir --c-include "pango/pangoxft.h"

Looks right.

@@ +441,3 @@
 PangoCairo_1_0_gir_PACKAGES = gobject-2.0 cairo
 PangoCairo_1_0_gir_EXPORT_PACKAGES = pangocairo
+PangoCairo_1_0_gir_INCLUDES = GObject-2.0 cairo-1.0

Looks right too.
Comment 2 Rico Tzschichholz 2011-07-15 17:17:59 UTC 
I know the first change isn't really needed, but i figured it makes it easier to understand why the scannerflags were incomplete.
Comment 3 Matthias Clasen 2011-07-16 22:55:07 UTC 
I don't think Behdad is touching the introspection build bits, so if some of this is needed, you should probably just commit it, Colin.
Comment 4 Colin Walters 2011-07-22 15:05:39 UTC 
*** Bug 635399 has been marked as a duplicate of this bug. ***