GNOME Bugzilla – Bug 654656
Improve XGenericEventCookie allocation wrt other toolkits
Last modified: 2011-07-15 12:19:01 UTC
Created attachment 192010 [details] [review] patch Right now, Clutter tries to allocate/free every XGenericEvent that gets through its ClutterDeviceManagerXI2, this unfortunately doesn't play well if both GTK+ and Clutter are to handle X Events in the same application, as the cookie data can be allocated just once for each cookie event, so it needs to persist throughout all handlers. I'm attaching a patch that improves the allocation schema, so it is only guaranteed to allocate the cookie when clutter gets the event itself via XNextEvent(), and only frees a cookie that it has allocated itself.
Review of attachment 192010 [details] [review]: the patch looks okay to me. typo alert in the commit message: "hipothetically" instead of "hypothetically". :-)
Typo fixed and pushed :)