After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654577 - Use CLUTTER_CAIRO_FORMAT_ARGB32: rather then doing a byte order check
Use CLUTTER_CAIRO_FORMAT_ARGB32: rather then doing a byte order check
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-07-13 20:25 UTC by drago01
Modified: 2011-07-13 21:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use CLUTTER_CAIRO_FORMAT_ARGB32: rather then doing a byte order check (5.03 KB, patch)
2011-07-13 20:25 UTC, drago01 		committed Details | Review

Description drago01 2011-07-13 20:25:51 UTC 
See patch (also makes us require clutter 1.7 but mutter does that anyway).
Comment 1 drago01 2011-07-13 20:25:53 UTC 
Created attachment 191922 [details] [review]
Use CLUTTER_CAIRO_FORMAT_ARGB32: rather then doing a byte order check

Clutter 1.7.x introduced CLUTTER_CAIRO_FORMAT_ARGB32: which can be used when
sharing textures/data with cairo without having to do check the
byte order and choose the appropriate format by hand.
Comment 2 Owen Taylor 2011-07-13 20:37:35 UTC 
Review of attachment 191922 [details] [review]:

Note non-endian safe uses of COGL_PIXEL_FORMAT_BGRA_8888 in shell-recorder.c that should be fixed as well. Otherwise, good to commit.
Comment 3 drago01 2011-07-13 21:12:43 UTC 
Attachment 191922 [details] pushed as 0f49f36 - Use CLUTTER_CAIRO_FORMAT_ARGB32: rather then doing a byte order check with the recorder fixes.