GNOME Bugzilla – Bug 654557
Grab handles should be configurable by theme
Last modified: 2014-03-17 18:54:13 UTC
Created attachment 191890 [details] [review] Patch to add style property The corner grab handles on a window are set on by default, but this should be configurable by the theme. In the case of the Ubuntu theme we've now configured the windows manager so that it creates an invisible border region that is selectable, making the handles not required for a reasonable resizing experience. It is also makes sense that other themes with large borders would not want the grab handles as well. This patch makes it a style property to whether they are shown by default on windows. It still allows applications to override that setting if they really, really want a grab handle for some reason.
Review of attachment 191890 [details] [review]: ::: gtk/gtkwindow.c @@ +947,3 @@ + gtk_widget_class_install_style_property (widget_class, + g_param_spec_boolean ("resize-grip-default", default-resize-grip I'd say here. @@ +1124,3 @@ + gboolean resize_default = TRUE; + gtk_widget_style_get (window, + "resize-grip-default", &resize_default, &(priv->has_resize_grip) should work here.
Created attachment 196078 [details] Screenshot of resize grips on win32 This also helps the win32 port as the resize grips look out of place there.
Can't you set resize-grip-width and resize-grip-height to zero on themes that don't want those to be drawn instead of adding another style property?
(In reply to comment #3) > Can't you set resize-grip-width and resize-grip-height to zero on themes that > don't want those to be drawn instead of adding another style property? It seems to work on win32 if I edit share/themes/Raleigh/gtk-3.0/gtk.css and add: * { -GtkWindow-resize-grip-height: 0; -GtkWindow-resize-grip-width: 0; } Think I'm missing something obvious here, but is there a way to do that from some file in etc/gtk-3.0?
(In reply to comment #4) > Think I'm missing something obvious here, but is there a way to do > that from some file in etc/gtk-3.0? I don't think so, it's a style property that needs to be overridden by the current theme as you did.
@@ +1124,3 @@ + gboolean resize_default = TRUE; + gtk_widget_style_get (window, + "resize-grip-default", &resize_default, &(priv->has_resize_grip) should work here. Wouldn't this only get the value of whether the window had a grip, not if the default was that it would have a grip? Seems those are potentially different values for some programs.
> Can't you set resize-grip-width and resize-grip-height to zero on > themes that don't want those to be drawn instead of adding another > style property? You could, but that would mean that all thumbs would be hidden. Which, seems to me, would be a bit brash. I think that it's reasonable to expect that some programs would be designed expecting the thumb in the corner, and removing it would alter them in a negative way. By changing the default value we're only changing the state of the thumb in applications that haven't specified a preference on whether it exists or not. Which seems like a more reasonable thing for a theme to be able to choose.
I don't think we'll make any changes here.