Created attachment 191860 [details] [review]
gnome-shell-jhbuild.in: Fix launch_component

Those gconf keys have been gone for a long while now. To replace the "smart"
code that was there before would be to extract the proper keyfile and parse
it, so just be stupid and launch the system gnome-shell.

Review of attachment 191860 [details] [review]:

If we care about replacing GNOME 2.28 still (do we?) then this will break it. 

If you want to make this still work, you'd have to test whether or not the gconf keys exist.  If you don't, the commit message should say we don't care anymore.

Rather than removing launch_component though, I'd just subprocess.Popen(['gnome-shell'])

Created attachment 191899 [details] [review]
gnome-shell-jhbuild.in: Fix restore_gnome.

The gconf keys used to restore GNOME aren't in a proper GNOME3 environment.
To mimic what GNOME3 gnome-session does would be extremely complicated, so
just launch the system gnome-shell.

Review of attachment 191899 [details] [review]:

One minor issue, otherwise looks OK I guess.

::: src/gnome-shell-jhbuild.in
@@ +551,3 @@
             appinfo.launch()
+            return True
+        return False

We're still returning None if the gconf key doesn't exist.  I'd fix it to return False too.

Attachment 191899 [details] pushed as 297eab7 - gnome-shell-jhbuild.in: Fix restore_gnome.


Pushed with suggested fix. Thanks!