After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654512 - Add some more triggers
Add some more triggers
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2011-07-12 23:59 UTC by Matthias Clasen
Modified: 2011-07-15 21:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (4.46 KB, patch)
2011-07-12 23:59 UTC, Matthias Clasen 		committed Details | Review

Description Matthias Clasen 2011-07-12 23:59:57 UTC 
Created attachment 191853 [details] [review]
patch

Here is a patch that adds triggers for some more caches.
Note that these are entirely untested.
Comment 1 Colin Walters 2011-07-13 19:51:53 UTC 
Review of attachment 191853 [details] [review]:

::: triggers/desktop-database.trigger
@@ +18,3 @@
+
+# IfExecutable: update-desktop-database
+# REMatch: /applications/*\.desktop

That should be '.*'  not just '*'; these are regexps, not globs.  I'd write this as:

/share/applications/.*/.*\.desktop

::: triggers/immodules.trigger
@@ +18,3 @@
+
+# IfExecutable: gtk-query-immodules-3.0
+# REMatch: /lib.*/gtk-3.0/3.0.0/immodules/*\.so

To be more strictly correct, you should quote the literal . in version numbers.  Also, same glob issue.  So:

/lib.*/gtk-3\.0/3\.0\.0/immodules/.*\.so

::: triggers/mime-database.trigger
@@ +18,3 @@
+
+# IfExecutable: update-mime-database
+# REMatch: /mime/packages/*\.xml

/mime/packages/.*\.xml