After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654495 - failure to adjust conditional formatting
failure to adjust conditional formatting
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: GUI
git master
Other Linux
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
: 674954 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-07-12 17:56 UTC by Andreas J. Guelzow
Modified: 2013-02-08 15:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
sample file (8.14 KB, application/x-gnumeric)
2011-07-12 17:56 UTC, Andreas J. Guelzow 		  Details
Preliminary patch (16.78 KB, patch)
2013-02-06 02:26 UTC, Morten Welinder 		none Details | Review
Updated patch (14.71 KB, patch)
2013-02-06 14:13 UTC, Morten Welinder 		none Details | Review
Updated patch (2.84 KB, patch)
2013-02-07 21:25 UTC, Morten Welinder 		none Details | Review

Description Andreas J. Guelzow 2011-07-12 17:56:46 UTC 
Created attachment 191829 [details]
sample file

Consider the attached file. 

A1 has an conditional red background whenever B1 is equal to "x". Changing B1 shows A1 changing as expected.

A3 has a conditional font style (bold & underline) whenever B3 is equal to "x". Changing B3 has no effect on A3's formatting. Clearly something is not connected correctly.
Comment 1 Andreas J. Guelzow 2011-07-12 21:06:45 UTC 
Hmm, somehow the change in Bx triggers Ax to redraw (for x=1 or 3). When Ax is being redrawn we always determine the true background colour, so it change. We do not rerender the cell content (that would take much too long). So whatever triggers the redrawing of Ax should force the rerendering of the value of Ax too.

Unfortunately I have no idea how the redrawing is triggered and using gdb add many additional redraws on every status change of the Gnumeric window...
Comment 2 Morten Welinder 2012-04-25 19:48:37 UTC 
My guess is that we are not hooking of conditional formats at all.
(Running with GNM_DEBUG=deps and pressing the lightbulb icon shows no
dependencies at all.)

Re gdb: for this kind of thing having a separate screen for gdb works best.
Comment 3 Morten Welinder 2013-02-06 02:26:45 UTC 
Created attachment 235279 [details] [review]
Preliminary patch

Here's a start.
Comment 4 Morten Welinder 2013-02-06 02:28:03 UTC 
*** Bug 674954 has been marked as a duplicate of this bug. ***
Comment 5 Morten Welinder 2013-02-06 14:13:59 UTC 
Created attachment 235312 [details] [review]
Updated patch

Reduced patch after committing changes not really related to style deps.
Comment 6 Morten Welinder 2013-02-07 21:25:10 UTC 
Created attachment 235451 [details] [review]
Updated patch

Not much left...
Comment 7 Morten Welinder 2013-02-08 15:18:21 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.