After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654475 - Get rid of shell_get_tp_contacts
Get rid of shell_get_tp_contacts
Status: RESOLVED OBSOLETE
Product: gnome-shell
Classification: Core
Component: message-tray
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on: 618193 654406
Blocks:
 
 
Reported: 2011-07-12 13:57 UTC by Guillaume Desmottes
Modified: 2012-02-08 11:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove shell_get_tp_contacts() C wrapper (6.48 KB, patch)
2011-08-04 10:06 UTC, Guillaume Desmottes
none Details | Review
remove shell_get_self_contact_features() C wrapper (4.23 KB, patch)
2011-08-04 10:06 UTC, Guillaume Desmottes
none Details | Review

Description Guillaume Desmottes 2011-07-12 13:57:54 UTC
Once bug #654406 we could get rid of the shell_get_tp_contacts() wrapper.
Comment 1 Guillaume Desmottes 2011-08-04 10:06:45 UTC
Created attachment 193236 [details] [review]
Remove shell_get_tp_contacts() C wrapper

gjs is smarter now so we don't need it any more.
Comment 2 Guillaume Desmottes 2011-08-04 10:06:48 UTC
Created attachment 193237 [details] [review]
remove shell_get_self_contact_features() C wrapper
Comment 3 Guillaume Desmottes 2011-08-04 10:07:23 UTC
This is still blocked by bug #654406 but can already be reviewed.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-02-08 03:49:42 UTC
http://git.gnome.org/browse/gnome-shell/commit/?id=5cf06fe9a7e1273565644245c4554934cb627ff7 removed both functions, so I guess there's nothing left to do here?
Comment 5 Guillaume Desmottes 2012-02-08 11:57:20 UTC
Yep, we're good!