GNOME Bugzilla – Bug 654398
Should use tp_text_channel_ack_all_pending_messages_async()
Last modified: 2011-08-04 08:56:55 UTC
Empathy just switched to tp_text_channel_ack_all_pending_messages_async() to ack messages. All the pending messages should always be acked, keeping unacked messages around isn't useful and may confuse UI as the same channel will be recreated as soon it's closed.
Created attachment 191729 [details] [review] Always ack all pending messages Keeping unacked messages is useless, may consume lot of memory and will cause channels to be respawned when being closed. We continue to keep a list of displayed pending messages to properly update the source count.
Review of attachment 191729 [details] [review]: This commit message is misleading: it implies that we leave no message unacked. How about: Don't save unacked messages Don't bother tracking which messages we need to ACK, just tell Telepathy to ACK them all.
Created attachment 191730 [details] [review] Always ack all pending messages We use to ack all displayed pending messages, we now ack all the pending messages even those not displayed. Keeping unacked messages is useless, may consume lot of memory (unacked messages stay in memory until connection is disconnected) and will cause channels to be respawned when being closed. We continue to keep a list of displayed pending messages to properly update the source count.
Review of attachment 191730 [details] [review]: I'd still like a better commit message. Again, this implies that we don't leave any message unacked, but in reality we just don't bother passing the messages we know are unacked back to telepathy.
Just give me the commit message you'd like and let's be done with this.
Created attachment 193229 [details] [review] Don't save unacked messages Don't bother tracking which messages we need to ACK, just tell Telepathy to ACK them all.
Merged to master as cb1966612e0aeae8eb316c05bda6dfcc223fbc53 This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.