After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654349 - Port to new GJS array and callback interface
Port to new GJS array and callback interface
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-07-10 16:43 UTC by Giovanni Campagna
Modified: 2011-08-08 21:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix methods that take array arguments (1.06 KB, patch)
2011-07-10 16:43 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2011-07-10 16:43:16 UTC 
A lot of changes happened in gjs recently, the most important being that length must not be passed to functions expecting arrays. This affects the notification-daemon component, when apps use custom icons.
Other changes could be to remove various ad-hoc wrappers in shell-util, given that now multiple callbacks are implemented.
Comment 1 Giovanni Campagna 2011-07-10 16:43:37 UTC 
Created attachment 191637 [details] [review]
Fix methods that take array arguments

Length parameter is no longer required in current GJS. Fix that.
Comment 2 Giovanni Campagna 2011-07-11 18:18:16 UTC 
Comment on attachment 191637 [details] [review]
Fix methods that take array arguments

Attachment 191637 [details] pushed as 6773664 - Fix methods that take array arguments
Keeping open in case there is something else we can or need to do
Comment 3 Colin Walters 2011-08-08 21:21:49 UTC 
I think we're good on this now.