Bug 654302 - postasa plugin doesn't build with libgdata 0.9.x
postasa plugin doesn't build with libgdata 0.9.x
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: plugins
3.1.x
Other Linux
: Normal normal
: GNOME3.2
Assigned To: EOG Maintainers
EOG Maintainers
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2011-07-09 16:50 UTC by Vincent Untz
Modified: 2011-07-11 20:39 UTC (History)
1 user (show)

See Also:
GNOME target: ---
GNOME version: ---


Attachments

Description Vincent Untz 2011-07-09 16:50:32 UTC
eog-postasa-plugin.c: In function 'uploads_add_entry':
eog-postasa-plugin.c:310:2: warning: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'goffset' [-Wformat]
eog-postasa-plugin.c: In function 'picasaweb_upload_files':
eog-postasa-plugin.c:524:2: warning: implicit declaration of function 'gdata_service_is_authenticated' [-Wimplicit-function-declaration]
eog-postasa-plugin.c: In function 'picasaweb_login_async_cb':
eog-postasa-plugin.c:574:2: warning: implicit declaration of function 'gdata_service_authenticate_finish' [-Wimplicit-function-declaration]
eog-postasa-plugin.c: In function 'picasaweb_login_cb':
eog-postasa-plugin.c:615:2: warning: implicit declaration of function 'gdata_service_authenticate_async' [-Wimplicit-function-declaration]
eog-postasa-plugin.c: In function 'login_get_dialog':
eog-postasa-plugin.c:733:4: warning: implicit declaration of function 'gdata_service_get_username' [-Wimplicit-function-declaration]
eog-postasa-plugin.c:733:4: warning: passing argument 2 of 'gtk_entry_set_text' makes pointer from integer without a cast [enabled by default]
/usr/include/gtk-3.0/gtk/gtkentry.h:176:12: note: expected 'const gchar *' but argument is of type 'int'
eog-postasa-plugin.c:734:4: warning: implicit declaration of function 'gdata_service_get_password' [-Wimplicit-function-declaration]
eog-postasa-plugin.c:734:4: warning: passing argument 2 of 'gtk_entry_set_text' makes pointer from integer without a cast [enabled by default]
/usr/include/gtk-3.0/gtk/gtkentry.h:176:12: note: expected 'const gchar *' but argument is of type 'int'
eog-postasa-plugin.c: In function 'eog_postasa_plugin_init':
eog-postasa-plugin.c:816:2: warning: passing argument 1 of 'gdata_picasaweb_service_new' from incompatible pointer type [enabled by default]
/usr/include/libgdata/gdata/services/picasaweb/gdata-picasaweb-service.h:66:24: note: expected 'struct GDataAuthorizer *' but argument is of type 'char *'

The gdata API being used there doesn't exist anymore.
Comment 1 Felix Riemann 2011-07-10 14:31:49 UTC
Oh no!
Tested it against the wrong libgdata version all the time. :(
Comment 2 Felix Riemann 2011-07-11 20:39:19 UTC
This should do it.
We should probably also look into supporting David Zeuthen's central account management thingy once it's ready.

commit 9d46bbfd50224e41f9d73933a7e31a60331691da
Author: Felix Riemann <>
Date:   Mon Jul 11 21:42:59 2011 +0200

    postasa: Add support for libgdata-0.9 API
    
    libgdata changed the authentication API in 0.9.0.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=654302

commit 1e568775603c65ff86a3bdf242b2065dcdf18414
Author: Felix Riemann <>
Date:   Sun Jul 10 16:29:16 2011 +0200

    postasa: Use correct printf-format string for goffset-value
    
    Fixes compiler warnings for 32bit targets.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=654302

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.

Note You need to log in before you can comment on or make changes to this bug.