After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654300 - Missing battery icon when building from g-s moduleset
Missing battery icon when building from g-s moduleset
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-07-09 15:41 UTC by Florian Müllner
Modified: 2011-07-13 17:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Remove upower from the moduleset (3.48 KB, patch)
2011-07-09 15:41 UTC, Florian Müllner
committed Details | Review
power: Remove _checkError() (1.97 KB, patch)
2011-07-09 15:41 UTC, Florian Müllner
committed Details | Review
build: Remove gnome-power-manager (1.55 KB, patch)
2011-07-09 15:41 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2011-07-09 15:41:43 UTC
Since commit c567690004 we use the g-s-d's power plugin for the status icon. But as it uses a upower function which was introduced after the 0.9.8 release, the plugin fails to load when build with the upower tarball in our moduleset. Rather than bumping the tarball version (or switch to master as the gnome-suites-core-3.2 moduleset), use a distro package instead.

The other patches remove the (now obsolete) dependency on gnome-power-manager.
Comment 1 Florian Müllner 2011-07-09 15:41:47 UTC
Created attachment 191584 [details] [review]
build: Remove upower from the moduleset

The upower version in the moduleset is too old for the power plugin
of gnome-settings-daemon. As at least Fedora and Ubuntu have a
recent enough version in their repositories, use that instead of
bumping the version in the moduleset.
Comment 2 Florian Müllner 2011-07-09 15:41:51 UTC
Created attachment 191585 [details] [review]
power: Remove _checkError()

On error, we tried to kill and respawn gnome-power-manager, but
as of commit c5676900 the DBus interface provided by g-s-d's power
plugin is used, so the respawning does not have any effect.
Comment 3 Florian Müllner 2011-07-09 15:41:56 UTC
Created attachment 191586 [details] [review]
build: Remove gnome-power-manager

The DBus interface for the battery status is now provided by the
power plugin of gnome-settings-daemon, so there's real reason to
keep building gnome-power-manager.
Comment 4 drago01 2011-07-13 17:42:12 UTC
Review of attachment 191584 [details] [review]:

Looks good.
Comment 5 drago01 2011-07-13 17:42:49 UTC
Review of attachment 191585 [details] [review]:

Looks good.
Comment 6 drago01 2011-07-13 17:44:07 UTC
Review of attachment 191586 [details] [review]:

Killing unneeded stuff from the module set is always a good thing ;)
Comment 7 Florian Müllner 2011-07-13 17:46:57 UTC
Attachment 191584 [details] pushed as bf28c24 - build: Remove upower from the moduleset
Attachment 191585 [details] pushed as fda4fc6 - power: Remove _checkError()
Attachment 191586 [details] pushed as 664245d - build: Remove gnome-power-manager

(In reply to comment #6)
> Killing unneeded stuff from the module set is always a good thing ;)

Yeah, but uncommon unfortunately ...