After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654259 - matroska: track INVISIBLE flag for vp8
matroska: track INVISIBLE flag for vp8
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-07-08 15:34 UTC by Oleksij Rempel
Modified: 2012-12-16 23:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch v1 (5.86 KB, patch)
2011-07-08 15:34 UTC, Oleksij Rempel
committed Details | Review

Description Oleksij Rempel 2011-07-08 15:34:24 UTC
Created attachment 191524 [details] [review]
patch v1

vp8 set an INVISIBLE flag for some frame which should not be displayed.
Matroska also has reserved bit for this kind of frames. This patch just use
this bit.
    
See Block Header and SimpleBlock Header sections.
http://www.matroska.org/technical/specs/index.html#simpleblock_structure
Comment 1 Tim-Philipp Müller 2012-10-27 12:25:38 UTC
Just out of curiosity: apart from exposing all the info there is - what's the point of doing this, esp. given the "google prefers not to do this, but it won't do any harm" comment ?
Comment 2 Oleksij Rempel 2012-10-27 12:39:52 UTC
We have different issues with I-Frames. Some of them was fixed in 0.10, and some came buck in different form in 1.0. I hope it makes it easy do triangle this problems. If you open a file an see this flags, then you can prepare your self for troubles :) or at least know where to look.
On other hand it is easier do make test case for decoder, if demuxer can tel which frame will be not displayed.

Is it enough? :)
Comment 3 Tim-Philipp Müller 2012-12-16 23:39:14 UTC
Sure, thanks for the explanation.

commit 7e47e3b92d794539d062ccff7b17d7d5c1f82a0f
Author: Alexey Fisher <bug-track@fisher-privat.net>
Date:   Sun Dec 16 23:27:41 2012 +0000

    matroskamux: set appropriate block header flag for VP8 invisible frames
    
    Useful for debugging mostly.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=654259

I've updated the patch for current git and made some minor changes (e.g. checking the keyframe flag only inside the simpl block where it was checked before).