After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654129 - bookmarks on toolbar show "..." instead of bookmark name
bookmarks on toolbar show "..." instead of bookmark name
Status: RESOLVED OBSOLETE
Product: epiphany
Classification: Core
Component: Controls
3.0.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-07-06 21:27 UTC by Adam Dingle
Modified: 2011-12-23 17:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (87.91 KB, image/png)
2011-07-06 21:27 UTC, Adam Dingle 		  Details
Don't ellipsize the label of bookmark toolbar items (1.36 KB, patch)
2011-10-15 10:29 UTC, Carlos Garcia Campos 		none Details | Review

Description Adam Dingle 2011-07-06 21:27:08 UTC 
I'm running Epiphany 3.0.3 on Ubuntu 11.10 (Oneiric).

If I show a bookmark on a toolbar (either by selecting Show on Toolbar in the Edit Bookmarks dialog, or by dragging a link to an existing toolbar) then the toolbar shows "..." in place of the bookmark name.  I think this is a relatively recent regression.

I'll attach a screenshot.
Comment 1 Adam Dingle 2011-07-06 21:27:36 UTC 
Created attachment 191427 [details]
screenshot
Comment 2 Carlos Garcia Campos 2011-10-15 10:22:38 UTC 
Yes, this is because GtkToolbar child property expand is FALSE and the label is using PANGO_ELLIPSIZE_END, so minimum size reported by the label is the size of "...".
Comment 3 Carlos Garcia Campos 2011-10-15 10:29:57 UTC 
Created attachment 199057 [details] [review]
Don't ellipsize the label of bookmark toolbar items
Comment 4 Diego Escalante Urrelo (not reading bugmail) 2011-10-17 05:55:32 UTC 
If the label exceeds TOOLITEM_WIDTH_CHARS, will it ellipsize?
Comment 5 Carlos Garcia Campos 2011-10-17 08:10:25 UTC 
(In reply to comment #4)
> If the label exceeds TOOLITEM_WIDTH_CHARS, will it ellipsize?

No.
Comment 6 Diego Escalante Urrelo (not reading bugmail) 2011-10-18 00:02:14 UTC 
That's bad :-/

Can't we fix this so it works as before? Meaning that it ellipsizes at the end after TOOLITEM_WIDTH_CHARS?

As a workaround this could be ok, but I'd rather restore the previous behavior.
Comment 7 Diego Escalante Urrelo (not reading bugmail) 2011-12-23 17:29:52 UTC 
This is no longer possible (won't) with Epiphany 3.4