After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654085 - Don't needlessly use "echo -e" when creating .def files
Don't needlessly use "echo -e" when creating .def files
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other Mac OS
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2011-07-06 13:56 UTC by Martin Storsjö
Modified: 2011-07-11 00:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
A patch fixing the issue (2.90 KB, patch)
2011-07-06 13:56 UTC, Martin Storsjö 		committed Details | Review
Don't needlessly use "echo -e" (2.95 KB, patch)
2011-07-11 00:48 UTC, Matthias Clasen 		committed Details | Review

Description Martin Storsjö 2011-07-06 13:56:28 UTC 
Created attachment 191398 [details] [review]
A patch fixing the issue

Echo is used for generating a header for .def files, when building for windows. Currently, this uses "echo -e EXPORTS", when run on a strict POSIX sh, it adds "-e EXPORTS" to the beginning of the file. The -e option (in bash) enables interpreting escaped characters, but no escaped characters have to be interpreted in this case when simply echoing "EXPORTS".

The attached patch changes "echo -e" into "echo" for these cases, fixing building glib with a mingw cross compiler on Mac OS X.
Comment 1 Matthias Clasen 2011-07-11 00:47:59 UTC 
The following fix has been pushed:
7c517bf Don't needlessly use "echo -e"
Comment 2 Matthias Clasen 2011-07-11 00:48:08 UTC 
Created attachment 191660 [details] [review]
Don't needlessly use "echo -e"

The -e parameter to echo isn't recognized by echo in POSIX sh,
but isn't needed when no escaped characters need to be
interpreted.

This fixes building glib with a mingw cross compiler on Mac OS X.