After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654027 - Change the Panel Size Minimum's behavior
Change the Panel Size Minimum's behavior
Status: RESOLVED OBSOLETE
Product: gnome-panel
Classification: Other
Component: panel
3.0.x
Other Linux
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-07-05 16:21 UTC by Juan Rodriguez
Modified: 2020-11-06 20:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Changes the default's panel minimum to 15px (961 bytes, patch)
2011-07-05 16:21 UTC, Juan Rodriguez
needs-work Details | Review

Description Juan Rodriguez 2011-07-05 16:21:55 UTC
Created attachment 191330 [details] [review]
Changes the default's panel minimum to 15px

On Gnome 3 on Fallback mode, the current minimum for the gnome-panel is set to 29px on my laptop. Back on Gnome 2.x it used to be set to 24px (And could go lower IIRC). 

Since Widescreen monitors are normal among laptop users, we could really use the extra pixels. 

I'm attaching a patch I made for the Fedora Gnome Panels RPM to set the minimum to 15px. I know this isn't a clean implementation, or even the preferred way of attaching a patch, but I wanted to get some discussion going to see the best way to change this. 

As a side note, the menu-bar on 3.x changes the panel size back to 29px once added, so I know I'm missing something somewhere.
Comment 1 André Klapper 2011-07-31 08:00:11 UTC
Not a clean patch (commented code), plus /* is prefered to //.
Comment 2 Daniel Weinstein 2011-10-02 21:36:39 UTC
I would like to add my voice to support this change.   There is no valid reason to require the minimum panel height to be so larger than 15 pixels.  In General the gnome designers make things way too big, and a 29pixel panel is just an unacceptable waste of space.   If the submitted patch isn't "clean", why not just take the 5 minutes necessary to clean it up, rather than reject it?
Comment 3 Juan Rodriguez 2011-10-02 21:48:50 UTC
Daniel: The patch I wrote is bad because the minimum height is calculated now, based on the 'smallest' available applet. Since the new Gnome Menu applet is now set at 29px, the patch should be submitted to the gnome menu applet, I think. 

Either way, I sorta lost interest in hacking Gnome altogether and have moved onto saner grounds.
Comment 4 Vincent Untz 2011-10-04 06:48:26 UTC
Comment on attachment 191330 [details] [review]
Changes the default's panel minimum to 15px

Indeed, this patch is not the right way to do things. The minimum height is computed automatically, so it's likely more something related to the theme and font size than anything else.
Comment 5 André Klapper 2020-11-06 20:23:20 UTC
bugzilla.gnome.org is being replaced by gitlab.gnome.org. We are closing all old bug reports in Bugzilla which have not seen updates for many years.

If you can still reproduce this issue in a currently supported version of GNOME (currently that would be 3.38), then please feel free to report it at https://gitlab.gnome.org/GNOME/gnome-panel/-/issues/

Thank you for reporting this issue and we are sorry it could not be fixed.