GNOME Bugzilla – Bug 653975
Update YouTube plugin to compile against libgdata ≥ 0.9.0
Last modified: 2011-12-14 10:58:28 UTC
The YouTube currently doesn't compile against libgdata ≥ 0.9.0 because it's broken API from version 0.8.x. Branch coming up which fixes this.
Created attachment 191256 [details] [review] Update YouTube plugin to compile against libgdata ≥ 0.9.0 https://gitorious.org/~pwithnall/grilo/pwithnalls-grilo-plugins/commits/653975-gdata-0-9 This branch is based on the 0.1.x branch, but should rebase to master fairly easily. As well as updating the plugin to support libgdata ≥ 0.9.0, it fixes a number of compiler warnings in the plugin too.
Hi Philip, Glancing your patches I see the one about the C90 conformance. Is it there a Gnome's convention in favor of C90 instead of C99??
(In reply to comment #2) > Hi Philip, > > Glancing your patches I see the one about the C90 conformance. Is it there a > Gnome's convention in favor of C90 instead of C99?? We use C90 everwhere.
*** Bug 653948 has been marked as a duplicate of this bug. ***
I see someone's pushed the patches to 0.1.x. They should also be rebased and pushed to master.
(In reply to comment #5) > I see someone's pushed the patches to 0.1.x. They should also be rebased and > pushed to master. Yes, I did it. I did not push them into master because I want to discuss with Juan and Iago if we should drop the support of older libgdata APIs (Juan is on vacations now). To maintain three API version is not sound to me. But, what is your opinion Philip?
(In reply to comment #6) > (In reply to comment #5) > > I see someone's pushed the patches to 0.1.x. They should also be rebased and > > pushed to master. > > Yes, I did it. I did not push them into master because I want to discuss with > Juan and Iago if we should drop the support of older libgdata APIs (Juan is on > vacations now). To maintain three API version is not sound to me. But, what is > your opinion Philip? I don't think there's much point in explicitly supporting versions older than 0.8.x, since 0.8.x is the current release. However, I don't think you should drop support for 0.8.x itself, since 0.9.x is an unstable release (which will eventually become the stable 0.10.0). It's up to you, really. I will continue to support 0.8.x for a while, but I won't be making micro releases for 0.7.x and 0.6.x any more.
(In reply to comment #6) > (In reply to comment #5) > > I see someone's pushed the patches to 0.1.x. They should also be rebased and > > pushed to master. > > Yes, I did it. I did not push them into master because I want to discuss with > Juan and Iago if we should drop the support of older libgdata APIs (Juan is on > vacations now). To maintain three API version is not sound to me. But, what is > your opinion Philip? I've applied this patch also to master.
(In reply to comment #7) > It's up to you, really. I will continue to support 0.8.x for a while, but I > won't be making micro releases for 0.7.x and 0.6.x any more. The real work is maintaining the support for 0.6.x and olders, as 0.7.x has the same api as 0.8.x So I've dropped support for libgdata < 0.7.
Closing the bug as fixed: commit 31572fcba82790e2e00fcc5bad59fc4d8b47cc6a Author: Philip Withnall <philip@tecnocode.co.uk> Date: Mon Jul 4 23:12:53 2011 +0100 youtube: Add support for compiling against libgdata <E2><89><A5> 0.9.0 This adds conditional support for compiling against libgdata <E2><89><A5> 0.9.0, which broke various APIs from 0.8.x. This fixes https://bugzilla.gnome.org/show_bug.cgi?id=653975.