After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653959 - clutter-actor: Don't apply shaders during picking
clutter-actor: Don't apply shaders during picking
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2011-07-04 18:00 UTC by Neil Roberts
Modified: 2011-07-05 12:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
clutter-actor: Don't apply shaders during picking (2.03 KB, patch)
2011-07-04 18:00 UTC, Neil Roberts
accepted-commit_now Details | Review

Description Neil Roberts 2011-07-04 18:00:01 UTC
Commit 0ede622f5132 inadvertently made it so that shaders are applied
during picking. This was making test-shader fail to respond to clicks.

The commit also makes it so that culling is applied during
picking. Presumably this is also unintentional because the commit
message does not mention it. However I think it may make sense to do
culling during picking so it might as well stay that way.
Comment 1 Neil Roberts 2011-07-04 18:00:03 UTC
Created attachment 191241 [details] [review]
clutter-actor: Don't apply shaders during picking
Comment 2 Emmanuele Bassi (:ebassi) 2011-07-04 22:20:26 UTC
Review of attachment 191241 [details] [review]:

looks good.
Comment 3 Neil Roberts 2011-07-05 12:39:54 UTC
Pushed as 805d27fb0