After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653803 - EmpathyLogWindow should be a GtkWindow
EmpathyLogWindow should be a GtkWindow
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Archives
3.1.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks: 653760
 
 
Reported: 2011-07-01 09:38 UTC by Emilio Pozuelo Monfort
Modified: 2011-07-04 11:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Emilio Pozuelo Monfort 2011-07-01 09:38:43 UTC 
We need this to fix #653760
Comment 1 Emilio Pozuelo Monfort 2011-07-01 16:36:36 UTC 
http://cgit.collabora.com/git/user/pochu/empathy.git/log/?h=log-viewer-gobject

I'd like to make the .ui not contain the GtkWindow but only the GtkBox, but if I do that, empathy fails to load things from the .ui file, so I need to do gtk_widget_reparent for now...
Comment 2 Guillaume Desmottes 2011-07-04 07:43:34 UTC 
(In reply to comment #1)
> http://cgit.collabora.com/git/user/pochu/empathy.git/log/?h=log-viewer-gobject

++
 
> I'd like to make the .ui not contain the GtkWindow but only the GtkBox, but if
> I do that, empathy fails to load things from the .ui file, so I need to do
> gtk_widget_reparent for now...

Is that GtkBuilder bug? I'd open one then.
Comment 3 Emilio Pozuelo Monfort 2011-07-04 11:33:03 UTC 
I've found out it was my fault. GTK+ keeps a reference on top-level widgets (e.g. the GtkWindow we had) so when we were unreffing the builder, it wasn't destroyed. But it doesn't keep a reference on other widgets, so when I made the vbox not a child of a GtkWindow, loaded it, and unreffed the GtkBuilder*, the GtkBuilder* removed its reference on the GtkVBox, so it was destroyed.

I'm not packing the GtkVBox before unreffing the GtkBuilder to fix it. See the last commit (I'll amend before merging).
Comment 4 Emilio Pozuelo Monfort 2011-07-04 11:52:31 UTC 
Merged to master