After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653753 - [PATCH] Show in Unity too
[PATCH] Show in Unity too
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-06-30 15:58 UTC by Michael Terry
Modified: 2011-07-05 17:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add Unity (2.69 KB, patch)
2011-07-05 12:55 UTC, Michael Terry 		accepted-commit_now Details | Review

Description Michael Terry 2011-06-30 15:58:02 UTC 
Unity is a registered XDG environment [1].  Unity uses gnome-keyring
so the .desktop file should add it to its OnlyShowIn value.

This isn't particularly relevant this second, but will be once the patch in bug
653440 lands.

[1] http://standards.freedesktop.org/menu-spec/latest/apb.html
Comment 1 Stef Walter 2011-07-05 08:36:47 UTC 
Yes, we should certainly add Unity. If you post a patch here, I'll review it right away.
Comment 2 Michael Terry 2011-07-05 12:55:01 UTC 
Created attachment 191314 [details] [review]
Add Unity

Hah, whoops, must have forgotten to upload this patch.  Sorry!
Comment 3 Stef Walter 2011-07-05 17:17:25 UTC 
Review of attachment 191314 [details] [review]:

Thanks. Looks good. Please push to gnome-keyring master.
Comment 4 Michael Terry 2011-07-05 17:25:48 UTC 
commit 79ef2cfd2079569b92f9452baeef2c1bec7b448d
Author: Michael Terry <michael.terry@canonical.com>
Date:   Tue Jul 5 08:53:55 2011 -0400

    Add Unity to OnlyShowIn
    
    https://bugzilla.gnome.org/show_bug.cgi?id=653753