After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653752 - gnome-bluetooth-1.0.pc: Fix libdir, also add rpath
gnome-bluetooth-1.0.pc: Fix libdir, also add rpath
Status: RESOLVED FIXED
Product: gnome-bluetooth
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-bluetooth-general-maint@gnome.bugs
gnome-bluetooth-general-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2011-06-30 15:54 UTC by Colin Walters
Modified: 2011-09-08 17:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gnome-bluetooth-1.0.pc: Fix libdir, also add rpath (1022 bytes, patch)
2011-06-30 15:54 UTC, Colin Walters 		none Details | Review
gnome-bluetooth-1.0.pc: Add variables for accessing applet library (950 bytes, patch)
2011-06-30 17:28 UTC, Colin Walters 		accepted-commit_now Details | Review

Description Colin Walters 2011-06-30 15:54:03 UTC 
The -L${libdir} was just wrong; the .so lives in ${libdir/gnome-bluetooth.

Also, as a general rule for libraries installed in private directories, we
should also insert an rpath.
Comment 1 Colin Walters 2011-06-30 15:54:05 UTC 
Created attachment 191039 [details] [review]
gnome-bluetooth-1.0.pc: Fix libdir, also add rpath
Comment 2 Bastien Nocera 2011-06-30 16:02:44 UTC 
(In reply to comment #0)
> The -L${libdir} was just wrong; the .so lives in ${libdir/gnome-bluetooth.

No, it doesn't. The .so for libgnome-bluetooth-applet does, not libgnome-bluetooth.
Comment 3 Colin Walters 2011-06-30 17:28:21 UTC 
Created attachment 191043 [details] [review]
gnome-bluetooth-1.0.pc: Add variables for accessing applet library

This will be used by gnome-shell; slightly better than hardcoding the
library path there.
Comment 4 Bastien Nocera 2011-06-30 17:59:55 UTC 
Review of attachment 191043 [details] [review]:

Looks good
Comment 5 Bastien Nocera 2011-09-08 09:53:25 UTC 
Colin, still needed?
Comment 6 Colin Walters 2011-09-08 17:09:21 UTC 
This was already committed.