GNOME Bugzilla – Bug 653750
[PATCH] Show in Unity too
Last modified: 2011-07-01 09:42:48 UTC
Unity is a registered XDG environment [1]. Unity uses gnome-bluetooth so the .desktop file should add it to its OnlyShowIn value. This isn't particularly relevant this second, but will be once the patch in bug 653440 lands. [1] http://standards.freedesktop.org/menu-spec/latest/apb.html
Created attachment 191038 [details] [review] Add Unity
Review of attachment 191038 [details] [review]: If you want the applet to get autostarted under Unity, you'll need to ship your own .desktop file. ::: applet/bluetooth-applet.desktop.in.in @@ +7,3 @@ Type=Application Categories= +OnlyShowIn=GNOME;XFCE;Unity; You do realise that the .desktop file as it is won't launch under Unity, at all, right?
> You do realise that the .desktop file as it is won't launch under Unity, at > all, right? Oh, right, because of the GNOME3 condition? How would you feel about a patch that makes that condition "unless-session gnome-shell"?
(or rather "unless-session gnome" -- I got the session name wrong)
(In reply to comment #4) > (or rather "unless-session gnome" -- I got the session name wrong) That would make it launch in the gdm session. I'd rather you shipped your own autostart desktop file for Unity (just like I'd rather gnome-session shipped that particular desktop file).
> I'd rather you shipped your own autostart desktop file for Unity I notice that XFCE is also affected by the session conditional (it's currently in your OnlyShowIn line but won't match the 'gnome-fallback' session name). It makes more sense to me to have a non-shell-oriented .desktop file be shipped with gnome-bluetooth rather than only in the Ubuntu packaging. Would you accept a patch that added that additional .desktop file (with "OnlyShowIn=XFCE;Unity;" so that it doesn't affect GNOME Shell). Alternatively, one could patch gnome-session to accept multiple sessions in its if-session conditional. But session names are a bit less spec'd than the XDG environment names so I prefer the previous solution. > just like I'd rather gnome-session shipped that particular desktop file Sorry, I don't understand which desktop file you were referring to with this statement. (The one that launches gnome-bluetooth in Unity?)
(In reply to comment #6) > > I'd rather you shipped your own autostart desktop file for Unity > > I notice that XFCE is also affected by the session conditional (it's currently > in your OnlyShowIn line but won't match the 'gnome-fallback' session name). The XFCE spin for Fedora went with blueman. The GNOME Bluetooth applet is integrated with GNOME, and will launch gnome-control-center for the Bluetooth prefs, as well as for the various device prefs (sound, keyboard, mouse). That's not really something usable for XFCE. > It makes more sense to me to have a non-shell-oriented .desktop file be shipped > with gnome-bluetooth rather than only in the Ubuntu packaging. Would you > accept a patch that added that additional .desktop file (with > "OnlyShowIn=XFCE;Unity;" so that it doesn't affect GNOME Shell). Given that you already a big libappindicator patch downstream, what's one more patch? I'll be fine with shipping another desktop file downstream with "Unity" as the sole desktop if you can get the app indicator stuff implemented in a way that doesn't cause me to keep receiving crash reports. > Alternatively, one could patch gnome-session to accept multiple sessions in its > if-session conditional. But session names are a bit less spec'd than the XDG > environment names so I prefer the previous solution. > > > just like I'd rather gnome-session shipped that particular desktop file > > Sorry, I don't understand which desktop file you were referring to with this > statement. (The one that launches gnome-bluetooth in Unity?) The desktop file you're patching, it shouldn't really be in gnome-bluetooth, but in gnome-session, just like the policykit agent helper.
After talking with hadess and seb128, Ubuntu's going to do what hadess suggested and make a standalone bluetooth indicator. So I'll mark this wontfix, as Ubuntu can carry this patch itself until the standalone indicator lands.