After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653748 - No accessible name set for the default window
No accessible name set for the default window
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Robert Roth
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-06-30 14:44 UTC by Robert Roth
Modified: 2014-02-23 18:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1.96 KB, patch)
2013-12-20 12:26 UTC, Robert Roth 		reviewed Details | Review

Description Robert Roth 2011-06-30 14:44:35 UTC 
The empty Document Viewer (with no documents open) does not seem to have an accessible name set.
Comment 1 Robert Roth 2011-06-30 14:46:53 UTC 
Originally reported downstream in Ubuntu, see https://bugs.launchpad.net/evince/+bug/704928.
Comment 2 Robert Roth 2013-12-20 12:26:56 UTC 
Created attachment 264610 [details] [review]
Proposed patch

Set the window title to "Document Viewer" for the empty window to have the accessible name properly set.
Comment 3 Carlos Garcia Campos 2014-02-23 18:00:37 UTC 
Review of attachment 264610 [details] [review]:

Thanks for the patch, I've just committed a slightly different patch, see below

::: shell/ev-window-title.c
@@ +169,3 @@
 		break;
+	case EV_WINDOW_TITLE_DOCUMENT:
+	default:

This is not correct, the window title type can only be password or document.

::: shell/ev-window.c
@@ +7328,3 @@
 	g_signal_connect (ev_window, "window_state_event",
 			  G_CALLBACK (window_state_event_cb), NULL);
+	gtk_window_set_title (GTK_WINDOW (ev_window), _("Document Viewer"));

Instead of having two different was of setting the window, I think EvWindowTitle should set the default title when created.