After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653620 - telepathyClient.js: pass more callbacks to async functions
telepathyClient.js: pass more callbacks to async functions
Status: RESOLVED OBSOLETE
Product: gnome-shell
Classification: Core
Component: message-tray
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-06-29 08:30 UTC by Guillaume Desmottes
Modified: 2011-07-04 07:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
pass a callback when calling channel.close_async() (1009 bytes, patch)
2011-06-29 08:32 UTC, Guillaume Desmottes 		none Details | Review
pass a callback when calling cd.present_channel_async() (999 bytes, patch)
2011-06-29 08:32 UTC, Guillaume Desmottes 		none Details | Review
pass a callback when calling _client.delegate_channels_async() (1.17 KB, patch)
2011-06-29 08:33 UTC, Guillaume Desmottes 		none Details | Review

Description Guillaume Desmottes 2011-06-29 08:30:58 UTC 
Because of a recent gjs change we now have to pass callback to all our _async calls.
Comment 1 Guillaume Desmottes 2011-06-29 08:32:56 UTC 
Created attachment 190911 [details] [review]
pass a callback when calling channel.close_async()
Comment 2 Guillaume Desmottes 2011-06-29 08:32:59 UTC 
Created attachment 190912 [details] [review]
pass a callback when calling cd.present_channel_async()
Comment 3 Guillaume Desmottes 2011-06-29 08:33:03 UTC 
Created attachment 190913 [details] [review]
pass a callback when calling _client.delegate_channels_async()
Comment 4 Guillaume Desmottes 2011-06-29 08:33:47 UTC 
(In reply to comment #3)
> Created an attachment (id=190913) [details] [review]
> pass a callback when calling _client.delegate_channels_async()

This one is blocked on bug #652753 but we can already merge the 2 first patches.
Comment 5 Dan Winship 2011-06-29 12:07:01 UTC 
If we want to get things working again quickly, then feel free to commit these, but leave the bug open; I think we probably want to get bug 653484 in, and then they can be reverted again.
Comment 6 Guillaume Desmottes 2011-07-04 07:36:15 UTC 
Bug #653484 has been fixed so we don't need this any more.