GNOME Bugzilla – Bug 653602
Gnome Contacts shouldn't assume TpfPersonas contain valid TpContacts
Last modified: 2011-09-01 19:02:02 UTC
It's been fair to assume this historically, but that will no longer be true once we've merged the fix for bug #652643. Cached Tpf.Personas will contain a null TpContact (ie, they will be for display purposes only, not for actions).
Created attachment 190895 [details] [review] Un-break gnome-contacts with the Tpf.Persona cache Patches from branch: http://cgit.collabora.com/git/user/treitter/gnome-contacts.git/log/?h=bgo653602-tpf-persona-cache
I picked up patch 2 and 4 from that series. But Patch 1 and 3 are about Contacts.Contact, not TpContact, which seems unrelated. Any reason these should be affected by a lacking TpContact, or was this just a mistake?
(In reply to comment #2) > I picked up patch 2 [details] and 4 from that series. But Patch 1 [details] and 3 are about > Contacts.Contact, not TpContact, which seems unrelated. Any reason these should > be affected by a lacking TpContact, or was this just a mistake? Those two aren't strictly required for this current bug but came up in the process. Would you like me to file a bug for each of them?
I don't see how there could ever come up an Individual that doesn't have a Contact, because all the Individual we handle are from a single aggregator, and in as soon as individuals are added to that we create a Contacts.Contact for it. But, if you ever find g-c looking up non-existing Contacts from individual, file a new bug with the details.