After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653599 - Empathy shouldn't assume all TpfPersonas contain a valid TpContact
Empathy shouldn't assume all TpfPersonas contain a valid TpContact
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Meta Contacts
3.1.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
: 656654 656896 656941 (view as bug list)
Depends on: 655911
Blocks: 652643
 
 
Reported: 2011-06-28 22:04 UTC by Travis Reitter
Modified: 2011-08-22 10:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't assume that all TpfPersonas contain a valid TpContact (27.58 KB, patch)
2011-06-28 22:10 UTC, Travis Reitter 		none Details | Review

Description Travis Reitter 2011-06-28 22:04:12 UTC 
It's been fair to assume this historically, but that will no longer be true once we've merged the fix for bug #652643. Cached Tpf.Personas will contain a null TpContact (ie, they will be for display purposes only, not for actions).
Comment 1 Travis Reitter 2011-06-28 22:10:36 UTC 
Created attachment 190893 [details] [review]
Don't assume that all TpfPersonas contain a valid TpContact

Note that it's safe to apply this patch before Folks has merged its PersonaStore cache (bug #652643).

Patches from branch:

http://cgit.collabora.com/git/user/treitter/empathy.git/log/?h=bgo653599-tpf-persona-cache
Comment 2 Travis Reitter 2011-06-28 22:11:52 UTC 
Adding this as a blocker for bug #652643, since Empathy needs these patches to work properly with the new cache.
Comment 3 Guillaume Desmottes 2011-08-22 09:33:33 UTC 
*** Bug 656654 has been marked as a duplicate of this bug. ***
Comment 4 Guillaume Desmottes 2011-08-22 09:34:16 UTC 
*** Bug 656896 has been marked as a duplicate of this bug. ***
Comment 5 Jonny Lamb 2011-08-22 09:38:53 UTC 
This should have been merged before the PersonaStore was merged.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 6 Guillaume Desmottes 2011-08-22 10:35:37 UTC 
*** Bug 656941 has been marked as a duplicate of this bug. ***