GNOME Bugzilla – Bug 653592
Open picture in default image viewer
Last modified: 2011-06-29 09:33:18 UTC
Created attachment 190888 [details] [review] Patch that adds this enhancement I've just started using Frogr and I missed a way of viewing the images in a bigger size so I thought a good idea was to be able to open it in the default image viewer. With this patch, the details' dialog will show the picture (when viewed individually) inside a button which brings it up with the image viewer when clicked. Hope it is useful for you as well.
I liked it! And the patch looks good to me so I already push it (keeping authorship, of course): http://git.gnome.org/browse/frogr/commit/?id=a49bc074fb8d5ec51949cfbac32a3240cddc9740 Also, I added a couple of commits on top of yours to reuse the frogr_util_open_uri() function instead of gtk_show_uri(), so we make sure it works properly in old versions of GTK2 and the Mac. Thanks!
Cool, thanks for pushing it. I think the "Open in default image viewer" should also be available from the View menu and/or the context menu so we don't need to access the details' dialog. Cheers,
(In reply to comment #2) > Cool, thanks for pushing it. > > I think the "Open in default image viewer" should also be available from the > View menu and/or the context menu so we don't need to access the details' > dialog. I agree with being able to open an image both through the context menu and the menu, what I'm not sure about is whether "View" is the right place to put such an option, I think the "Actions" menu is a better place for that (another thing that is arguable is the "Actions" name, of course :-)). Also, we must take care of the case where multiple images are selected and we use one of those new menu items. I think the way to go is just to open them all and let the recipient app to operate as it wishes (e.g. eog will open all of them with one single window, allowing to iterate over them). I wrote a new util function that you can use for that: frogr_util_open_multiple_uris (const gchar *uris) It's not tested at all yet, so if you find it doesn't work as you expect feel free to fix it too :-) Ah, last but not least, I personally do not think opening a new bug for that is needed, but I'd rather leave the decision to you, and if you finally reuse this bug, I'd just ask you to reopen it so we can still track down the progress. Thanks!