GNOME Bugzilla – Bug 653560
libebook tests: Run in private D-Bus session,with the locally-built service
Last modified: 2018-10-17 15:26:02 UTC
Created attachment 190844 [details] [review] 0001-addressbook-tests-Run-with-private-D-Bus-session-and.patc This patch makes the ebook client tests run only after starting a private D-Bus session and explicitly starting the locally-built e-addressbook-factory service. Some tests give warnings which should probably be investigated, and some seem to take so long that they are maybe only stopping (successfully) after a timeout. But they seem like separate issues. Other tests may need a similar system, but this is a start.
Can I get some response to this patch, please?
This patch still applies cleanly to master? May I push it?
Thanks for the patch, and sorry about the long delay in responding. Eventually I'd like to replace the shell script with a test harness that uses GTestDBus [1], but for now I'll take anything that just makes the tests work again. Please commit to master. [1] http://developer.gnome.org/gio/stable/GTestDBus.html
Pushed a couple of days ago. Thanks.
Actually I only just pushed it now, plus a small extra commit to update this for a recent change: http://git.gnome.org/browse/evolution-data-server/commit/?id=3898e39f3d5c6d74ba1e821f198f2ab110e193a2 And now I see that the tests produce some warnings, because they try to print details for a specific contact ID, but I don't see anything that adds this ID in the database: http://git.gnome.org/browse/evolution-data-server/tree/tests/libebook/client/test-client.c?id=3898e39f3d5c6d74ba1e821f198f2ab110e193a2#n83 static void print_one_email (EBookClient *book_client) { e_book_client_get_contact (book_client, "pas-id-0002023", NULL, print_email_cb, NULL); } Is that just a bad test, or am I missing something?
This work was probably replaced and improved-upon by Tristan's more recent work, though I guess that the problems in the actual test code remain.
The code in question really changed, there is no "pas-id-0002023" in the code anymore, thus I'm closing this as fixed.