After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653560 - libebook tests: Run in private D-Bus session,with the locally-built service
libebook tests: Run in private D-Bus session,with the locally-built service
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: general
3.2.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2011-06-28 09:47 UTC by Murray Cumming
Modified: 2018-10-17 15:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-addressbook-tests-Run-with-private-D-Bus-session-and.patc (7.85 KB, patch)
2011-06-28 09:47 UTC, Murray Cumming
committed Details | Review

Description Murray Cumming 2011-06-28 09:47:59 UTC
Created attachment 190844 [details] [review]
0001-addressbook-tests-Run-with-private-D-Bus-session-and.patc

This patch makes the ebook client tests run only after starting a private D-Bus session and explicitly starting the locally-built e-addressbook-factory service.

Some tests give warnings which should probably be investigated, and some seem to take so long that they are maybe only stopping (successfully) after a timeout. But they seem like separate issues.

Other tests may need a similar system, but this is a start.
Comment 1 Murray Cumming 2012-09-28 07:33:03 UTC
Can I get some response to this patch, please?
Comment 2 Murray Cumming 2012-11-23 09:38:10 UTC
This patch still applies cleanly to master? May I push it?
Comment 3 Matthew Barnes 2012-11-24 04:11:46 UTC
Thanks for the patch, and sorry about the long delay in responding.

Eventually I'd like to replace the shell script with a test harness that uses GTestDBus [1], but for now I'll take anything that just makes the tests work again.

Please commit to master.

[1] http://developer.gnome.org/gio/stable/GTestDBus.html
Comment 4 Murray Cumming 2012-11-27 08:31:54 UTC
Pushed a couple of days ago. Thanks.
Comment 5 Murray Cumming 2012-11-27 13:01:15 UTC
Actually I only just pushed it now, plus a small extra commit to update this for a recent change:
http://git.gnome.org/browse/evolution-data-server/commit/?id=3898e39f3d5c6d74ba1e821f198f2ab110e193a2

And now I see that the tests produce some warnings, because they try to print details for a specific contact ID, but I don't see anything that adds this ID in the database:

http://git.gnome.org/browse/evolution-data-server/tree/tests/libebook/client/test-client.c?id=3898e39f3d5c6d74ba1e821f198f2ab110e193a2#n83

static void
print_one_email (EBookClient *book_client)
{
	e_book_client_get_contact (book_client, "pas-id-0002023", NULL, print_email_cb, NULL);
}

Is that just a bad test, or am I missing something?
Comment 6 Murray Cumming 2013-02-24 20:50:16 UTC
This work was probably replaced and improved-upon by Tristan's more recent work, though I guess that the problems in the actual test code remain.
Comment 7 Milan Crha 2018-10-17 15:26:02 UTC
The code in question really changed, there is no "pas-id-0002023" in the code anymore, thus I'm closing this as fixed.