After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653544 - [basevideodecoder] Immediately forwards synchronized events
[basevideodecoder] Immediately forwards synchronized events
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.13
Other Linux
: Normal major
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-06-28 06:20 UTC by Sebastian Dröge (slomo)
Modified: 2011-10-29 15:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Sebastian Dröge (slomo) 2011-06-28 06:20:50 UTC 
Currently basevideodecoder immediately forwards EOS instead of waiting until _finish_frame() was called for the last frame. Instead it should probably set a flag and send EOS from _finish_frame()
Comment 1 Sebastian Dröge (slomo) 2011-06-28 06:42:53 UTC 
Also the EOS event should probably always be sent from _finish_frame() because the streaming thread of the sinkpad could be different than the streaming thread of the srcpad (e.g. decoder that provides decoded frames from a second thread)
Comment 2 Sebastian Dröge (slomo) 2011-06-28 09:59:30 UTC 
The same applies to all other synchronized events. They should be forwarded downstream before the next buffer or EOS is pushed downstream.
Comment 3 Sebastian Dröge (slomo) 2011-07-09 09:26:37 UTC 
commit f341386b64c5fd8f7f90cc47259b1a2ce2816ea9
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Tue Jun 28 11:47:25 2011 +0200

    basevideodecoder: Don't reorder serialized src events
    
    And allow to drop EOS by the subclass if ::finish returns
    DROPPED. This requires that the subclass sends EOS manually later.
    
    Fixes bug #653544.