After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653521 - automount: turn the automount plugin in a separate binary
automount: turn the automount plugin in a separate binary
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: automount
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on: 653520
Blocks:
 
 
Reported: 2011-06-27 20:08 UTC by Cosimo Cecchi
Modified: 2011-07-13 18:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
automount: turn the automount plugin in a separate binary (19.16 KB, patch)
2011-06-27 20:08 UTC, Cosimo Cecchi
committed Details | Review

Description Cosimo Cecchi 2011-06-27 20:08:11 UTC
When the automount machinery is moved to gnome-shell (see bug 653520), we want to disable the plugin in gnome-settings-daemon which does the same thing, but still be able to use it for fallback mode (and eventually remove it altogether when we're able to have a good software renderer fallback).
The easiest way to do this is to move the code to a separate process, and install an autostart desktop file with AutostartCondition=GNOME3 if-session gnome-fallback, which is what this patch does.
Comment 1 Cosimo Cecchi 2011-06-27 20:08:13 UTC
Created attachment 190810 [details] [review]
automount: turn the automount plugin in a separate binary

It will get autostarted only in fallback mode.
Comment 2 Bastien Nocera 2011-06-28 09:30:00 UTC
Review of attachment 190810 [details] [review]:

Leave the code where it was, should be fine.

::: Makefile.am
@@ +4,3 @@
 	gnome-settings-daemon	\
 	plugins			\
+	fallback		\

It's fine under plugins actually.
Comment 3 Cosimo Cecchi 2011-07-13 18:56:04 UTC
Thanks, I left the files in plugins/automount and committed everything to master now that the shell part has been committed too.

Attachment 190810 [details] pushed as 796958e - automount: turn the automount plugin in a separate binary