After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653512 - GtkEntryCompletion: Use a PAGE_STEP macro instead of a magic number
GtkEntryCompletion: Use a PAGE_STEP macro instead of a magic number
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2011-06-27 16:59 UTC by Claudio Saavedra
Modified: 2011-06-28 06:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use a PAGE_STEP macro instead of a magic number (2.05 KB, patch)
2011-06-27 16:59 UTC, Claudio Saavedra
committed Details | Review

Description Claudio Saavedra 2011-06-27 16:59:48 UTC
I had to go through git annotate to understand this, so let's just please use a macro instead.
Comment 1 Claudio Saavedra 2011-06-27 16:59:50 UTC
Created attachment 190778 [details] [review]
Use a PAGE_STEP macro instead of a magic number

Helps to understand the code.
Comment 2 Matthias Clasen 2011-06-27 20:52:03 UTC
Review of attachment 190778 [details] [review]:

Sure, sounds like a good idea.