GNOME Bugzilla – Bug 653479
address command-line argument for gnome-bluetooth shouldn't be quoted
Last modified: 2011-06-27 16:00:35 UTC
Created attachment 190747 [details] [review] Don't quote destination address Right now sending files to a bluetooth (paired) device from gnome-shell via: - click on bluetooth applet - click on device - click on send files .. fails because the address of the destination device is received with extra quotes (i.e.: \"5C:57:C8:C4:XX:XX\"). We could either unquote that from bluetooth-sendto or avoid the quotes entirely since there are no spaces nor conflicting characters in addresses. The attached patch does the latter.
> since there are no spaces nor conflicting characters in addresses. It is not because there are no spaces or conflicting characters but because g_spawn_async() doesn't need quotes. It either uses execve(2) which does not need quotes or it escapes and protects the string on Windows. So it works even if there was spaces :) The same change should be done in other part of the code: applet/bluetooth-applet.c::bluetooth_applet_send_to_address s = g_strdup_printf ("--device=%s", address); s = g_strdup_printf ("--name=%s", alias); moblin/moblin-panel.c::send_file_button_clicked_cb s = g_strdup_printf ("--device=%s", address); s = g_strdup_printf ("--name=%s", name); In the MeeGo branch, there is an additional change: applet/main.c::sendto_callback s = g_strdup_printf ("--device=%s", address); s = g_strdup_printf ("--name=%s", alias);
Created attachment 190752 [details] [review] Removal of other parameters which need no quotes Remove the other quotes as pointed out by Alban.
Created attachment 190753 [details] [review] Patch for the MeeGo branch
If somebody still cares of the meego branch, they can merge that last patch.
*** Bug 645642 has been marked as a duplicate of this bug. ***