After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653473 - x264enc: "subme" property value can go up to 10
x264enc: "subme" property value can go up to 10
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other Linux
: Normal normal
: 0.10.19
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-06-27 11:07 UTC by Brian G. Marete
Modified: 2011-06-27 12:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[gstx264enc] Annotate maximum subme property value property correctly (1.49 KB, patch)
2011-06-27 11:07 UTC, Brian G. Marete 		none Details | Review

Description Brian G. Marete 2011-06-27 11:07:48 UTC 
Created attachment 190742 [details] [review]
[gstx264enc]   Annotate maximum subme property value property correctly

Although the element accepts subme values > 6, the annotation which is
visible through gst-inspect (for example) erroneously indicates 6 as the
maximum. Fix this by indicating 10 (which is the x264 max) as the maximum.


A patch to fix this which should apply against the latest GIT is attached.
Comment 1 Tim-Philipp Müller 2011-06-27 12:16:43 UTC 
Thanks for the patch!

 commit 48f899257db49b5289f754cbd92fce246854dd0f
 Author: Brian Gitonga Marete <marete@toshnix.com>
 Date:   Sat Jun 25 06:29:50 2011 +0300

    x264enc: fix subme property annotation - subme maximum is 10, not 6.
    
    Although the element accepts subme values > 6, the annotation which is
    visible through gst-inspect (for example) erroneously indicates 6 as the
    maximum. Fix this by indicating 10 (which is the x264 max) as the maximum.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=653473