After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653471 - login page js broken, MEDIA_URL assignment missing quotes
login page js broken, MEDIA_URL assignment missing quotes
Status: RESOLVED FIXED
Product: snowy
Classification: Deprecated
Component: general
git master
Other Mac OS
: Normal normal
: future
Assigned To: snowy-maint
snowy-maint
Depends on:
Blocks:
 
 
Reported: 2011-06-27 09:53 UTC by Leho Kraav (@lkraav :macmaN)
Modified: 2011-06-27 12:20 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Leho Kraav (@lkraav :macmaN) 2011-06-27 09:53:26 UTC
$ git diff
diff --git a/accounts/templates/accounts/login.html b/accounts/templates/accounts/login.html
index 12b165b..4b85253 100644
--- a/accounts/templates/accounts/login.html
+++ b/accounts/templates/accounts/login.html
@@ -7,7 +7,7 @@
 <script type="text/javascript" src="{{ MEDIA_URL }}js/accounts/openid-config.js"></script>
 <script type="text/javascript">
     // set the media URL to insert openid provider images in js
-    var MEDIA_URL = {{ MEDIA_URL }};
+    var MEDIA_URL = "{{ MEDIA_URL }}";
 </script>
 <script type="text/javascript" src="{{ MEDIA_URL }}js/accounts/login.js"></script>
Comment 1 Leho Kraav (@lkraav :macmaN) 2011-06-27 09:55:38 UTC
Without quotes you get:

Error: invalid regular expression flag e
Source File: https://server/tomboy/accounts/login/ 
Line: 25, Column: 29  
Source Code: var MEDIA_URL = /tomboy/media/;
Comment 2 Jeff Schroeder 2011-06-27 12:20:28 UTC
Pushed as 9d4671b23aba, thanks Leho!