GNOME Bugzilla – Bug 653471
login page js broken, MEDIA_URL assignment missing quotes
Last modified: 2011-06-27 12:20:28 UTC
$ git diff diff --git a/accounts/templates/accounts/login.html b/accounts/templates/accounts/login.html index 12b165b..4b85253 100644 --- a/accounts/templates/accounts/login.html +++ b/accounts/templates/accounts/login.html @@ -7,7 +7,7 @@ <script type="text/javascript" src="{{ MEDIA_URL }}js/accounts/openid-config.js"></script> <script type="text/javascript"> // set the media URL to insert openid provider images in js - var MEDIA_URL = {{ MEDIA_URL }}; + var MEDIA_URL = "{{ MEDIA_URL }}"; </script> <script type="text/javascript" src="{{ MEDIA_URL }}js/accounts/login.js"></script>
Without quotes you get: Error: invalid regular expression flag e Source File: https://server/tomboy/accounts/login/ Line: 25, Column: 29 Source Code: var MEDIA_URL = /tomboy/media/;
Pushed as 9d4671b23aba, thanks Leho!