GNOME Bugzilla – Bug 653349
SoupCache: incorrect types for some attributes in SoupCacheEntry
Last modified: 2011-06-29 15:40:13 UTC
The GVariant format string specifies that "u" -> guint32. We are storing (using the "u" character) some fields that are time_t, which is not guaranteed to be 32 bit (in some 64bit machines is 64bit while in some others is 32bit). It should be safe to store time_t in guint32 variables as it will take a lot of years to overflow those 32bit integer. Apart from that, looks like we can store the cache version as a guint16 instead of a guint32.
Created attachment 190596 [details] [review] Patch
Committed 26c53ff8015368e2eb29316bd5736c1423171544. Thx for the review!