After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653332 - Missing conversion from DBus 16 bit integers to JS
Missing conversion from DBus 16 bit integers to JS
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2011-06-24 12:18 UTC by Emmanuele Bassi (:ebassi)
Modified: 2011-06-24 14:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dbus: Add conversion rule for 'q' to JS (1.30 KB, patch)
2011-06-24 12:18 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review

Description Emmanuele Bassi (:ebassi) 2011-06-24 12:18:03 UTC 
Patch attached.
Comment 1 Emmanuele Bassi (:ebassi) 2011-06-24 12:18:05 UTC 
Created attachment 190580 [details] [review]
dbus: Add conversion rule for 'q' to JS

The int16/uint16 type (signature: 'q') is lacking the conversion rule
from DBus value to JavaScript. Easy enough to add.
Comment 2 Colin Walters 2011-06-24 13:15:11 UTC 
Review of attachment 190580 [details] [review]:

Looks good.
Comment 3 Emmanuele Bassi (:ebassi) 2011-06-24 14:29:42 UTC 
Thanks for the quick review. :-)

Attachment 190580 [details] pushed as 929d910 - dbus: Add conversion rule for 'q' to JS